rmaz added a comment. In D109632#3062608 <https://reviews.llvm.org/D109632#3062608>, @vsapsai wrote:
> I can be wrong but I like writing less data as it can result in savings for > more projects. For example, if compile time is dominated by method > deserialization and not by `Sema::addMethodToGlobalList`, we still should see > an improvement. I can try to experiment on a bunch of other projects and > their heavy .m files and report the results, if you'd like. I think that would be a useful comparison, yes. For our code I consistently measure this approach as 10-20% slower on average, with very few outliers where the set deduplication approach is slower. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109632/new/ https://reviews.llvm.org/D109632 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
