dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land.
In D111270#3062802 <https://reviews.llvm.org/D111270#3062802>, @aeubanks wrote: > In D111270#3060484 <https://reviews.llvm.org/D111270#3060484>, @dblaikie > wrote: > >> Plan is still to address the "this only works with disable free" issue? >> (I've some preference that be addressed before this feature is turned on by >> default) > > https://reviews.llvm.org/D111767. Thanks for pushing back, this actually does > help a bit more with memory savings. I was worried that we'd be doing a bunch > of pointer chasing if we supported -clear-ast-before-backend without > -disable-free but couldn't measure any runtime regressions aside from some > nullifying tiny wins gained by this patch. Great, thanks for that! >> & is there a flag to pass to turn this off if someone had trouble with it? >> (doesn't necessarily have to be, but just checking) > > Just like `-disable-free` doesn't have a flag, I don't want one for this at > least for now. I'd rather just revert this change and fix any issues. If we > come across weird issues then we may have to add a flag. Yep, sounds good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111270/new/ https://reviews.llvm.org/D111270 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
