ChuanqiXu marked 2 inline comments as done. ChuanqiXu added inline comments.
================ Comment at: clang/test/SemaCXX/co_await-range-for-exp-namespace.cpp:54 for - co_await(auto i : arr) {} + co_await(auto i : arr) {} // expected-warning {{Found deprecated std::experimental}} // expected-error@-1 {{call to deleted member function 'await_transform'}} ---------------- Quuxplusone wrote: > ChuanqiXu wrote: > > Quuxplusone wrote: > > > I'd like to see the next word in this diagnostic. (Ditto throughout. I'd > > > also like to make sure that the diagnostic is not being printed with > > > single-quotes in the wrong place, e.g. `Found deprecated > > > std::experimental::'coroutine_handle'`; if it is, please fix that.) > > > > > > This code is also misindented; please fix it up, as long as you're > > > touching it. Should be > > > ``` > > > for co_await (auto i : arr) {} > > > ``` > > Oh, clang-format couldn't recognize the new grammar. I need to be careful > > to use it to format codes. > FYI: I'd prefer a space before the `(`. Compare `for (~~~)`, `for co_await > (~~~)`. (I've left a comment in the clang-format Discord channel, too.) Thanks for issuing this! ================ Comment at: libcxx/test/libcxx/experimental/language.support/support.coroutines/dialect_support.pass.cpp:10 // REQUIRES: fcoroutines-ts -// ADDITIONAL_COMPILE_FLAGS: -fcoroutines-ts +// ADDITIONAL_COMPILE_FLAGS: -fcoroutines-ts -Wno-coroutine ---------------- Quuxplusone wrote: > Doesn't the change in lit.local.cfg make this change redundant? Yeah, this test isn't covered by `lit.local.cfg` below. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113977/new/ https://reviews.llvm.org/D113977 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits