jcking1034 marked an inline comment as done.
jcking1034 added inline comments.


================
Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1022
+  std::string getName() const override {
+    return "HasOverloadedOperatorNameMatcher";
+  }
----------------
ymandel wrote:
> here and below: drop the "Matcher" suffix?
Done. I've realized that this is a separate issue, but I'm still somewhat 
concerned about how the `HasOverloadedOperatorNameMatcher` is used in two 
different matchers, such that both `hasOverloadedOperatorName` and 
`hasAnyOverloadedOperatorName` will both have the name 
"HasOverloadedOperatorName".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113917/new/

https://reviews.llvm.org/D113917

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to