brettw added inline comments.
================ Comment at: clang-tools-extra/clang-doc/Representation.h:119-123 + // This variant (that takes no qualified name parameter) uses the Name as the + // QualName (very useful in unit tests to reduce verbosity). This can't use + // the empty string as a default because the global namespace uses + // "GlobalNamespace" as the name, but should have an empty QualName + // (corresponding to the name in code). ---------------- paulkirth wrote: > Does this imply that its illegal to use `""` as the name with this > constructor? if so, it probably requires at least an assert. No, I meant something else, clarified. ================ Comment at: clang-tools-extra/clang-doc/Representation.h:210-212 + // The literal contents of the code for everything that specifies this + // template parameter. This will include all components, so for a template + // declaration it could be "typename T = int". ---------------- paulkirth wrote: > I think this is equivalent. Do you mean this contains //all// instantiations > of the parameter across the codebase? or for a single declaration? Clarified CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
