karka228 wrote:

> Can you also add a test showing the difference between `-Wformat 
> -Wformat-signedness` and `-Wformat-signedness` by itself (which does nothing)?

With the current implementation `-Wformat-signedness` by itself actually turn 
on the signedness warnings. This is not compatible with how gcc do it. I guess 
I have thought that it was not that important to be compatible with gcc in this 
respect. However if it is I guess this could be implemented.

> I'd also like to see a test demonstrating that `#pragma GCC diagnostic 
> ignored -Wformat` disables the signedness warnings.

There is a single test in the end of 
clang/test/Sema/format-strings-signedness.c that demonstrate this.


https://github.com/llvm/llvm-project/pull/74440
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to