llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) <details> <summary>Changes</summary> Currently we're using official publication of CWG issue list available at https://www.open-std.org/jtc1/sc22/wg21/docs/cwg_index.html. Unfortunately, it's not updated as frequently as we sometimes need. For instance, recently there was a confusion during review of CWG2149 test (https://github.com/llvm/llvm-project/pull/90079#discussion_r1580174003). This patch changes our `make_cxx_dr_status` script to use issue list from CWG GitHub repository. I confirmed with CWG chair that this is the most up-to-date source of information on CWG issues. Changing the source of issue list uncovered previously unhandled "tentatively ready" status of an issue. This status is considered unresolved by the script (like `open`, `drafting`, and `review`), as the resolution might change during face-to-face CWG meeting. I also noticed that CWG decided to handle 2561 differently from what we're doing, so this DR is now considered not available in Clang, despite being declared as available since 18. CC @<!-- -->cor3ntin. This patch also brings new issues into our DR list, so if someone was waiting for a newly-filed issue to appear on our status page, it should appear with this PR. --- Patch is 54.73 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/90352.diff 8 Files Affected: - (modified) clang/test/CXX/drs/cwg2149.cpp (+1-1) - (modified) clang/test/CXX/drs/dr20xx.cpp (+1-1) - (modified) clang/test/CXX/drs/dr21xx.cpp (+2) - (modified) clang/test/CXX/drs/dr24xx.cpp (+2-2) - (modified) clang/test/CXX/drs/dr25xx.cpp (+3-1) - (modified) clang/test/CXX/drs/dr28xx.cpp (+1-1) - (modified) clang/www/cxx_dr_status.html (+397-156) - (modified) clang/www/make_cxx_dr_status (+3-3) ``````````diff diff --git a/clang/test/CXX/drs/cwg2149.cpp b/clang/test/CXX/drs/cwg2149.cpp index d0f8cb2dfc0a93..8416e42cbd6970 100644 --- a/clang/test/CXX/drs/cwg2149.cpp +++ b/clang/test/CXX/drs/cwg2149.cpp @@ -11,7 +11,7 @@ // cxx98-error@-1 {{variadic macros are a C99 feature}} #endif -namespace cwg2149 { // cwg2149: 3.1 drafting 2024-04 +namespace cwg2149 { // cwg2149: 3.1 #if __cplusplus <= 201103L struct X { int i, j, k; }; #else diff --git a/clang/test/CXX/drs/dr20xx.cpp b/clang/test/CXX/drs/dr20xx.cpp index 291a77e0cc71dd..9797097acce753 100644 --- a/clang/test/CXX/drs/dr20xx.cpp +++ b/clang/test/CXX/drs/dr20xx.cpp @@ -90,7 +90,7 @@ namespace cwg2026 { // cwg2026: 11 } } -namespace cwg2049 { // cwg2049: 18 drafting P2308R1 +namespace cwg2049 { // cwg2049: 18 #if __cplusplus >= 202302L template <int* x = {}> struct X {}; X<> a; diff --git a/clang/test/CXX/drs/dr21xx.cpp b/clang/test/CXX/drs/dr21xx.cpp index 4fab10c279aa43..082deb42e4fa09 100644 --- a/clang/test/CXX/drs/dr21xx.cpp +++ b/clang/test/CXX/drs/dr21xx.cpp @@ -175,6 +175,8 @@ void foo() { } } +// cwg2149 is in cwg2149.cpp + namespace cwg2157 { // cwg2157: 11 #if __cplusplus >= 201103L enum E : int; diff --git a/clang/test/CXX/drs/dr24xx.cpp b/clang/test/CXX/drs/dr24xx.cpp index 5ffaebda68c132..9f876cd8708347 100644 --- a/clang/test/CXX/drs/dr24xx.cpp +++ b/clang/test/CXX/drs/dr24xx.cpp @@ -45,7 +45,7 @@ void fallthrough(int n) { #endif } -namespace cwg2450 { // cwg2450: 18 review P2308R1 +namespace cwg2450 { // cwg2450: 18 #if __cplusplus >= 202302L struct S {int a;}; template <S s> @@ -59,7 +59,7 @@ f<{.a= 0}>(); #endif } -namespace cwg2459 { // cwg2459: 18 drafting P2308R1 +namespace cwg2459 { // cwg2459: 18 #if __cplusplus >= 202302L struct A { constexpr A(float) {} diff --git a/clang/test/CXX/drs/dr25xx.cpp b/clang/test/CXX/drs/dr25xx.cpp index 62b2a0a088cc13..481ae09cdb77ea 100644 --- a/clang/test/CXX/drs/dr25xx.cpp +++ b/clang/test/CXX/drs/dr25xx.cpp @@ -130,12 +130,14 @@ struct D3 : B { #endif #if __cplusplus >= 202302L -namespace cwg2561 { // cwg2561: 18 review 2023-11-09 +namespace cwg2561 { // cwg2561: no struct C { constexpr C(auto) { } }; void foo() { constexpr auto b = [](this C) { return 1; }; + // FIXME: closure type shouldn't have a conversion function to function + // pointer, because explicit object parameter is present. constexpr int (*fp)(C) = b; static_assert(fp(1) == 1); static_assert((&decltype(b)::operator())(1) == 1); diff --git a/clang/test/CXX/drs/dr28xx.cpp b/clang/test/CXX/drs/dr28xx.cpp index 4d9b0c76758d53..1967e8b751db2d 100644 --- a/clang/test/CXX/drs/dr28xx.cpp +++ b/clang/test/CXX/drs/dr28xx.cpp @@ -10,7 +10,7 @@ // expected-no-diagnostics #endif -namespace cwg2847 { // cwg2847: 19 +namespace cwg2847 { // cwg2847: 19 review 2024-03-01 #if __cplusplus >= 202002L diff --git a/clang/www/cxx_dr_status.html b/clang/www/cxx_dr_status.html index ea8872c91be604..19d29cb55d6ed0 100755 --- a/clang/www/cxx_dr_status.html +++ b/clang/www/cxx_dr_status.html @@ -1433,11 +1433,11 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> <td>Is indirection through a null pointer undefined behavior?</td> <td class="unknown" align="center">Unknown</td> </tr> - <tr class="open" id="233"> + <tr id="233"> <td><a href="https://cplusplus.github.io/CWG/issues/233.html";>233</a></td> - <td>drafting</td> + <td>tentatively ready</td> <td>References vs pointers in UDC overload resolution</td> - <td align="center">Not resolved</td> + <td class="unknown" align="center">Unknown</td> </tr> <tr id="234"> <td><a href="https://cplusplus.github.io/CWG/issues/234.html";>234</a></td> @@ -2756,7 +2756,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="453"> <td><a href="https://cplusplus.github.io/CWG/issues/453.html";>453</a></td> - <td>tentatively ready</td> + <td>DR</td> <td>References may only bind to “valid” objects</td> <td class="unknown" align="center">Unknown</td> </tr> @@ -5812,7 +5812,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr class="open" id="1001"> <td><a href="https://cplusplus.github.io/CWG/issues/1001.html";>1001</a></td> - <td>drafting</td> + <td>review</td> <td>Parameter type adjustment in dependent parameter types</td> <td align="center">Not resolved</td> </tr> @@ -6034,7 +6034,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="1038"> <td><a href="https://cplusplus.github.io/CWG/issues/1038.html";>1038</a></td> - <td>DR</td> + <td>DRWP</td> <td>Overload resolution of <TT>&x.static_func</TT></td> <td class="unknown" align="center">Unknown</td> </tr> @@ -9994,7 +9994,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="1698"> <td><a href="https://cplusplus.github.io/CWG/issues/1698.html";>1698</a></td> - <td>DR</td> + <td>DRWP</td> <td>Files ending in <TT>\</TT></td> <td class="unknown" align="center">Unknown</td> </tr> @@ -10132,7 +10132,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr class="open" id="1721"> <td><a href="https://cplusplus.github.io/CWG/issues/1721.html";>1721</a></td> - <td>drafting</td> + <td>review</td> <td>Diagnosing ODR violations for static data members</td> <td align="center">Not resolved</td> </tr> @@ -11312,11 +11312,11 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> <td>decltype-qualified enumeration names</td> <td class="unknown" align="center">Unknown</td> </tr> - <tr class="open" id="1918"> + <tr id="1918"> <td><a href="https://cplusplus.github.io/CWG/issues/1918.html";>1918</a></td> - <td>open</td> + <td>CD5</td> <td><TT>friend</TT> templates with dependent scopes</td> - <td align="center">Not resolved</td> + <td class="unknown" align="center">Unknown</td> </tr> <tr class="open" id="1919"> <td><a href="https://cplusplus.github.io/CWG/issues/1919.html";>1919</a></td> @@ -11474,11 +11474,11 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> <td>New C incompatibilities</td> <td align="center">Not resolved</td> </tr> - <tr class="open" id="1945"> + <tr id="1945"> <td><a href="https://cplusplus.github.io/CWG/issues/1945.html";>1945</a></td> - <td>open</td> + <td>CD5</td> <td>Friend declarations naming members of class templates in non-templates</td> - <td align="center">Not resolved</td> + <td class="unknown" align="center">Unknown</td> </tr> <tr id="1946"> <td><a href="https://cplusplus.github.io/CWG/issues/1946.html";>1946</a></td> @@ -11530,7 +11530,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="1954"> <td><a href="https://cplusplus.github.io/CWG/issues/1954.html";>1954</a></td> - <td>tentatively ready</td> + <td>DR</td> <td><TT>typeid</TT> null dereference check in subexpressions</td> <td class="unknown" align="center">Unknown</td> </tr> @@ -12098,11 +12098,11 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> <td>C-style casts that cast away constness vs <TT>static_cast</TT></td> <td align="center">Not resolved</td> </tr> - <tr class="open" id="2049"> + <tr id="2049"> <td><a href="https://cplusplus.github.io/CWG/issues/2049.html";>2049</a></td> - <td>drafting</td> + <td>DRWP</td> <td>List initializer in non-type template default argument</td> - <td title="Clang 18 implements P2308R1 resolution" align="center">Not Resolved*</td> + <td class="full" align="center">Clang 18</td> </tr> <tr id="2050"> <td><a href="https://cplusplus.github.io/CWG/issues/2050.html";>2050</a></td> @@ -12130,7 +12130,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2054"> <td><a href="https://cplusplus.github.io/CWG/issues/2054.html";>2054</a></td> - <td>DR</td> + <td>DRWP</td> <td>Missing description of class SFINAE</td> <td class="unknown" align="center">Unknown</td> </tr> @@ -12418,7 +12418,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2102"> <td><a href="https://cplusplus.github.io/CWG/issues/2102.html";>2102</a></td> - <td>DR</td> + <td>DRWP</td> <td>Constructor checking in <I>new-expression</I></td> <td class="unknown" align="center">Unknown</td> </tr> @@ -12698,11 +12698,11 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> <td>Thread storage duration and order of initialization</td> <td align="center">Not resolved</td> </tr> - <tr class="open" id="2149"> + <tr id="2149"> <td><a href="https://cplusplus.github.io/CWG/issues/2149.html";>2149</a></td> - <td>drafting</td> + <td>DR</td> <td>Brace elision and array length deduction</td> - <td title="Clang 3.1 implements 2024-04 resolution" align="center">Not Resolved*</td> + <td class="full" align="center">Clang 3.1</td> </tr> <tr id="2150"> <td><a href="https://cplusplus.github.io/CWG/issues/2150.html";>2150</a></td> @@ -13318,7 +13318,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2252"> <td><a href="https://cplusplus.github.io/CWG/issues/2252.html";>2252</a></td> - <td>DR</td> + <td>DRWP</td> <td>Enumeration list-initialization from the same type</td> <td class="unknown" align="center">Unknown</td> </tr> @@ -14410,7 +14410,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr class="open" id="2434"> <td><a href="https://cplusplus.github.io/CWG/issues/2434.html";>2434</a></td> - <td>open</td> + <td>review</td> <td>Mandatory copy elision vs non-class objects</td> <td align="center">Not resolved</td> </tr> @@ -14504,11 +14504,11 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> <td>Thunks as an implementation technique for pointers to virtual functions</td> <td align="center">Extension</td> </tr> - <tr class="open" id="2450"> + <tr id="2450"> <td><a href="https://cplusplus.github.io/CWG/issues/2450.html";>2450</a></td> - <td>review</td> + <td>DRWP</td> <td><I>braced-init-list</I> as a <I>template-argument</I></td> - <td title="Clang 18 implements P2308R1 resolution" align="center">Not Resolved*</td> + <td class="full" align="center">Clang 18</td> </tr> <tr id="2451"> <td><a href="https://cplusplus.github.io/CWG/issues/2451.html";>2451</a></td> @@ -14558,11 +14558,11 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> <td>Value category of expressions denoting non-static member functions</td> <td class="unknown" align="center">Unknown</td> </tr> - <tr class="open" id="2459"> + <tr id="2459"> <td><a href="https://cplusplus.github.io/CWG/issues/2459.html";>2459</a></td> - <td>drafting</td> + <td>DRWP</td> <td>Template parameter initialization</td> - <td title="Clang 18 implements P2308R1 resolution" align="center">Not Resolved*</td> + <td class="full" align="center">Clang 18</td> </tr> <tr id="2460"> <td><a href="https://cplusplus.github.io/CWG/issues/2460.html";>2460</a></td> @@ -14662,7 +14662,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2476"> <td><a href="https://cplusplus.github.io/CWG/issues/2476.html";>2476</a></td> - <td>tentatively ready</td> + <td>DR</td> <td><I>placeholder-type-specifier</I>s and function declarators</td> <td class="unknown" align="center">Unknown</td> </tr> @@ -14830,7 +14830,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2504"> <td><a href="https://cplusplus.github.io/CWG/issues/2504.html";>2504</a></td> - <td>DR</td> + <td>DRWP</td> <td>Inheriting constructors from virtual base classes</td> <td class="none" align="center">No</td> </tr> @@ -14992,7 +14992,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2531"> <td><a href="https://cplusplus.github.io/CWG/issues/2531.html";>2531</a></td> - <td>DR</td> + <td>DRWP</td> <td>Static data members redeclared as constexpr</td> <td class="unknown" align="center">Unknown</td> </tr> @@ -15002,11 +15002,11 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> <td>Kind of pointer value returned by <TT>new T[0]</TT></td> <td align="center">Not resolved</td> </tr> - <tr class="open" id="2533"> + <tr id="2533"> <td><a href="https://cplusplus.github.io/CWG/issues/2533.html";>2533</a></td> - <td>review</td> + <td>DR</td> <td>Storage duration of implicitly created objects</td> - <td align="center">Not resolved</td> + <td class="unknown" align="center">Unknown</td> </tr> <tr id="2534"> <td><a href="https://cplusplus.github.io/CWG/issues/2534.html";>2534</a></td> @@ -15082,13 +15082,13 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2546"> <td><a href="https://cplusplus.github.io/CWG/issues/2546.html";>2546</a></td> - <td>tentatively ready</td> + <td>DR</td> <td>Defaulted secondary comparison operators defined as deleted</td> <td class="unknown" align="center">Unknown</td> </tr> <tr id="2547"> <td><a href="https://cplusplus.github.io/CWG/issues/2547.html";>2547</a></td> - <td>tentatively ready</td> + <td>DR</td> <td>Defaulted comparison operator function for non-classes</td> <td class="unknown" align="center">Unknown</td> </tr> @@ -15142,7 +15142,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2556"> <td><a href="https://cplusplus.github.io/CWG/issues/2556.html";>2556</a></td> - <td>DR</td> + <td>DRWP</td> <td>Unusable <TT>promise::return_void</TT></td> <td class="unknown" align="center">Unknown</td> </tr> @@ -15166,15 +15166,15 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2560"> <td><a href="https://cplusplus.github.io/CWG/issues/2560.html";>2560</a></td> - <td>tentatively ready</td> + <td>DR</td> <td>Parameter type determination in a <I>requirement-parameter-list</I></td> <td class="unknown" align="center">Unknown</td> </tr> - <tr class="open" id="2561"> + <tr id="2561"> <td><a href="https://cplusplus.github.io/CWG/issues/2561.html";>2561</a></td> - <td>review</td> + <td>tentatively ready</td> <td>Conversion to function pointer for lambda with explicit object parameter</td> - <td title="Clang 18 implements 2023-11-09 resolution" align="center">Not Resolved*</td> + <td class="none" align="center">No</td> </tr> <tr class="open" id="2562"> <td><a href="https://cplusplus.github.io/CWG/issues/2562.html";>2562</a></td> @@ -15214,7 +15214,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2568"> <td><a href="https://cplusplus.github.io/CWG/issues/2568.html";>2568</a></td> - <td>tentatively ready</td> + <td>DR</td> <td>Access checking during synthesis of defaulted comparison operator</td> <td class="unknown" align="center">Unknown</td> </tr> @@ -15226,7 +15226,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2570"> <td><a href="https://cplusplus.github.io/CWG/issues/2570.html";>2570</a></td> - <td>DR</td> + <td>DRWP</td> <td>Clarify constexpr for defaulted functions</td> <td class="unknown" align="center">Unknown</td> </tr> @@ -15332,11 +15332,11 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> <td>Visible side effects and initial value of an object</td> <td align="center">Not resolved</td> </tr> - <tr class="open" id="2588"> + <tr id="2588"> <td><a href="https://cplusplus.github.io/CWG/issues/2588.html";>2588</a></td> - <td>drafting</td> + <td>tentatively ready</td> <td>friend declarations and module linkage</td> - <td align="center">Not resolved</td> + <td class="unknown" align="center">Unknown</td> </tr> <tr class="open" id="2589"> <td><a href="https://cplusplus.github.io/CWG/issues/2589.html";>2589</a></td> @@ -15352,7 +15352,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2591"> <td><a href="https://cplusplus.github.io/CWG/issues/2591.html";>2591</a></td> - <td>DR</td> + <td>DRWP</td> <td>Implicit change of active union member for anonymous union in union</td> <td class="unknown" align="center">Unknown</td> </tr> @@ -15376,7 +15376,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2595"> <td><a href="https://cplusplus.github.io/CWG/issues/2595.html";>2595</a></td> - <td>DR</td> + <td>DRWP</td> <td>"More constrained" for eligible special member functions</td> <td class="unknown" align="center">Unknown</td> </tr> @@ -15406,7 +15406,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2600"> <td><a href="https://cplusplus.github.io/CWG/issues/2600.html";>2600</a></td> - <td>DR</td> + <td>DRWP</td> <td>Type dependency of placeholder types</td> <td class="unknown" align="center">Unknown</td> </tr> @@ -15574,7 +15574,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2628"> <td><a href="https://cplusplus.github.io/CWG/issues/2628.html";>2628</a></td> - <td>DR</td> + <td>DRWP</td> <td>Implicit deduction guides should propagate constraints</td> <td class="none" align="center">No</td> </tr> @@ -15610,7 +15610,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2634"> <td><a href="https://cplusplus.github.io/CWG/issues/2634.html";>2634</a></td> - <td>tentatively ready</td> + <td>DR</td> <td>Avoid circularity in specification of scope for friend class declarations</td> <td class="unknown" align="center">Unknown</td> </tr> @@ -15628,13 +15628,13 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2637"> <td><a href="https://cplusplus.github.io/CWG/issues/2637.html";>2637</a></td> - <td>tentatively ready</td> + <td>DR</td> <td>Injected-class-name as a <I>simple-template-id</I></td> <td class="unknown" align="center">Unknown</td> </tr> <tr id="2638"> <td><a href="https://cplusplus.github.io/CWG/issues/2638.html";>2638</a></td> - <td>tentatively ready</td> + <td>DR</td> <td>Improve the example for initializing by initializer list</td> <td class="unknown" align="center">Unknown</td> </tr> @@ -15748,7 +15748,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2657"> <td><a href="https://cplusplus.github.io/CWG/issues/2657.html";>2657</a></td> - <td>tentatively ready</td> + <td>DR</td> <td>Cv-qualification adjustment when binding reference to temporary</td> <td class="unknown" align="center">Unknown</td> </tr> @@ -15770,11 +15770,11 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> <td>Confusing term "this parameter"</td> <td align="center">Not resolved</td> </tr> - <tr class="open" id="2661"> + <tr id="2661"> <td><a href="https://cplusplus.github.io/CWG/issues/2661.html";>2661</a></td> - <td>open</td> + <td>DR</td> <td>Missing disambiguation rule for <I>pure-specifier</I> vs. <I>brace-or-equal-initializer</I></td> - <td align="center">Not resolved</td> + <td class="unknown" align="center">Unknown</td> </tr> <tr id="2662"> <td><a href="https://cplusplus.github.io/CWG/issues/2662.html";>2662</a></td> @@ -15814,7 +15814,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2668"> <td><a href="https://cplusplus.github.io/CWG/issues/2668.html";>2668</a></td> - <td>tentatively ready</td> + <td>DR</td> <td><TT>co_await</TT> in a <I>lambda-expression</I></td> <td class="unknown" align="center">Unknown</td> </tr> @@ -15838,7 +15838,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2> </tr> <tr id="2672"> <td><a href="https://cplusplus.github.io/CWG/issues/2672.html";>2672</a></... [truncated] `````````` </details> https://github.com/llvm/llvm-project/pull/90352 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
