llvmbot wrote:

<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Mohammed Keyvanzadeh (VoltrexKeyva)

<details>
<summary>Changes</summary>

Fix an LLVM coding standards inconformity by adding pointer qualifiers to 
`auto`-typed variables that deduce to pointer types.

See what the coding standards state 
[here](https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto).

---
Full diff: https://github.com/llvm/llvm-project/pull/91874.diff


1 Files Affected:

- (modified) clang/lib/Driver/Action.cpp (+3-3) 


``````````diff
diff --git a/clang/lib/Driver/Action.cpp b/clang/lib/Driver/Action.cpp
index 849bf6035ebd2..e642cde9dca37 100644
--- a/clang/lib/Driver/Action.cpp
+++ b/clang/lib/Driver/Action.cpp
@@ -246,8 +246,8 @@ void OffloadAction::doOnHostDependence(const 
OffloadActionWorkTy &Work) const {
 
 void OffloadAction::doOnEachDeviceDependence(
     const OffloadActionWorkTy &Work) const {
-  auto I = getInputs().begin();
-  auto E = getInputs().end();
+  auto *I = getInputs().begin();
+  auto *E = getInputs().end();
   if (I == E)
     return;
 
@@ -261,7 +261,7 @@ void OffloadAction::doOnEachDeviceDependence(
   if (HostTC)
     ++I;
 
-  auto TI = DevToolChains.begin();
+  auto *TI = DevToolChains.begin();
   for (; I != E; ++I, ++TI)
     Work(*I, *TI, (*I)->getOffloadingArch());
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/91874
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to