[
https://issues.apache.org/jira/browse/CASSANDRA-14688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736941#comment-16736941
]
Alex Petrov commented on CASSANDRA-14688:
-----------------------------------------
Thank you for adding this much needed doc!
+1 Patch looks good; just have a couple of nits:
* Bytes for lengths seem to be added in [big-endian
order|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/frame/checksum/ChecksummingTransformer.java#L353]
for checksumming (which is a default for protocol, too) and the code is
equivalent to doing {{ByteBuffer#putInt}}. Since ordering was handled
explicitly here, despite {{ByteBuffer}} overload for {{Checksum#of}}, do we
want to specify endianness here?
* This is more a code comment though, but since it's always good to have
mapping from code to protocol documentation, currently [numCompressedChunks
|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/frame/checksum/ChecksummingTransformer.java#L177]
is a variable that represents number of all chunks, not only compressed. Maybe
we'd like to change it to reduce ambiguity.
The rest of comments of even smaller significance are in the patch.
> Update protocol spec and class level doc with protocol checksumming details
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-14688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14688
> Project: Cassandra
> Issue Type: Task
> Components: Legacy/Documentation and Website
> Reporter: Sam Tunnicliffe
> Assignee: Sam Tunnicliffe
> Priority: Major
> Fix For: 4.0
>
>
> CASSANDRA-13304 provides an option to add checksumming to the frame body of
> native protocol messages. The native protocol spec needs to be updated to
> reflect this ASAP. We should also verify that the javadoc comments describing
> the on-wire format in
> {{o.a.c.transport.frame.checksum.ChecksummingTransformer}} are up to date.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
