[ https://issues.apache.org/jira/browse/CASSANDRA-14731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967544#comment-16967544 ]
Benedict Elliott Smith edited comment on CASSANDRA-14731 at 11/5/19 1:54 PM: ----------------------------------------------------------------------------- Hi [~abdulazizali]. Sure, you're welcome to take this ticket. It's a while since I thought about this, so I will have to acclimatise to the context again, but there appear to be two proposals in this ticket: 1) tracking those transient writes we perform _because of the failure detector,_ and these are going to happen in {{sendToHintedReplicas}}; 2) tracking success of a transient write, particularly for achieving the requested consistency level, and that would happen in {{AbstractWriteResponseHandler}} but, in retrospect, I'm not entirely sure what this would look like. was (Author: benedict): Hi [~abdulazizali]. Sure, you're welcome to take this ticket. It's a while since I thought about this, so I will have to acclimatise to the context again, but there appear to be two proposals in this ticket: 1) tracking those transient writes we perform _because of the failure detector,_ and these are going to happen in {{sendToHintedReplicas}}. If we want to track success of transient writes for achieving quorum, that would happen in {{AbstractWriteResponseHandler}} but, in retrospect, I'm not entirely sure what this would look like. > Transient Write Metrics > ----------------------- > > Key: CASSANDRA-14731 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14731 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core, Observability/Metrics > Reporter: Benedict Elliott Smith > Assignee: Abdul Aziz Ali > Priority: Low > Labels: metrics, transient-replication > Fix For: 4.x > > > While we record the number of attempt transient writes, we do not record how > successful these were. > Also, we do not count transient writes that happen due to the failure > detector. While these are distinct from those writes that happen > ‘speculatively’ due to slow responses, there’s a strong chance they will be > the most common form of transient write. It might be worth having separate > metrics. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org