[ 
https://issues.apache.org/jira/browse/CASSANDRA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051007#comment-17051007
 ] 

Ryan Svihla commented on CASSANDRA-15557:
-----------------------------------------

[PR|[https://github.com/rssvihla/cassandra/pull/1]][Code|[https://github.com/rssvihla/cassandra/tree/failing-test-15557]]

Ran the tests all night on two different servers and had no issues (whereas 
before on the same hardware I had 30 or 40 failures usually within 5 to 10 
minute).

The theory I have is this test got broken when the schema management changed in 
https://issues.apache.org/jira/browse/CASSANDRA-13426 and the test no longer 
was relying on client query state to set a timestamp as it was 
[here|[https://github.com/pcmanus/cassandra/commit/020960d727b882349aff00c17a1c46bf3c7f7a24#diff-43b2d530031e2f7ad4286bd05fed4ca0R253]|https://github.com/pcmanus/cassandra/commit/020960d727b882349aff00c17a1c46bf3c7f7a24#diff-43b2d530031e2f7ad4286bd05fed4ca0R253]and
 this logic appears to not have made it back in 
[here|[https://github.com/apache/cassandra/commit/207c80c1fd63dfbd8ca7e615ec8002ee8983c5d6#diff-50a7bf78bc4f943f42ce60c8768484a6R400]]
 which meant an occasional tie, but maybe I'm misreading it all, lots of code 
to go through in that PR.

The fix I used was one of the two proposed in 12997 (ie just using manual time 
stamp).

> Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest 
> testDropListAndAddListWithSameName
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15557
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15557
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: David Capwell
>            Assignee: Ryan Svihla
>            Priority: Normal
>             Fix For: 4.0-alpha
>
>
> https://app.circleci.com/jobs/github/dcapwell/cassandra/482/tests
> {code}
> junit.framework.AssertionFailedError: Invalid value for row 0 column 2 
> (mycollection of type list<text>), expected <null> but got <[first element]>
>       at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1070)
>       at 
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:91)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to