[ 
https://issues.apache.org/jira/browse/CASSANDRA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055682#comment-17055682
 ] 

Ryan Svihla commented on CASSANDRA-15557:
-----------------------------------------

I borrowed the code from 15303 and updated the PR. Some notes:

* There is an additional fix in there which is related to comparison of 
relations. This doesn't appear to be related to either Jira, but it makes sense 
at a glance, either way [~jasonstack] added it and he can comment
* Made ClientState.getTimestatmp() static and call it directly instead of 
FBUtilities.timestampMicros()

But I'm also ok with someone first merging in 15303, then I can do another PR 
based on that code base just with the changes that use 
ClientState.getTimetamp() instead of FBUtilities.timestampMicros().

 

 

> Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest 
> testDropListAndAddListWithSameName
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15557
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15557
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: David Capwell
>            Assignee: Ryan Svihla
>            Priority: Normal
>              Labels: pull-request-available
>             Fix For: 4.0-alpha
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> https://app.circleci.com/jobs/github/dcapwell/cassandra/482/tests
> {code}
> junit.framework.AssertionFailedError: Invalid value for row 0 column 2 
> (mycollection of type list<text>), expected <null> but got <[first element]>
>       at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1070)
>       at 
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:91)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to