[
https://issues.apache.org/jira/browse/CASSANDRA-14801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075201#comment-17075201
]
Josh McKenzie commented on CASSANDRA-14801:
-------------------------------------------
Thanks for raising that this is a thorny area of the code-base where specific
care needs to be taken. There would probably be a lot of value in a class level
comment on TokenMetaData.java indicating this for future people as they ramp on
the code-base (and likely other areas of the code-base as well!).
{quote}I can see you work at DataStax, so perhaps you have the time and skill
to dedicate to this, but please be confident before you address it, and be
willing to wait a while for a sufficient review.
{quote}
Regarding [earned authority|https://www.apache.org/theapacheway/]:
{quote}their influence is based on publicly earned merit – what they contribute
to the community. Merit lies with the individual, does not expire, is not
influenced by employment status or employer
{quote}
Please refrain from focusing on who is employed by whom and instead focus on
their individual merit and contribution to the code-base in the future.
> calculatePendingRanges no longer safe for multiple adjacent range movements
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-14801
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14801
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Coordination, Legacy/Distributed Metadata
> Reporter: Benedict Elliott Smith
> Assignee: Aleksandr Sorokoumov
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0, 4.0-beta
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Correctness depended upon the narrowing to a {{Set<InetAddressAndport>}},
> which we no longer do - we maintain a collection of all {{Replica}}. Our
> {{RangesAtEndpoint}} collection built by {{getPendingRanges}} can as a result
> contain the same endpoint multiple times; and our {{EndpointsForToken}}
> obtained by {{TokenMetadata.pendingEndpointsFor}} may fail to be constructed,
> resulting in cluster-wide failures for writes to the affected token ranges
> for the duration of the range movement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
