[
https://issues.apache.org/jira/browse/CASSANDRA-15393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175390#comment-17175390
]
Benedict Elliott Smith commented on CASSANDRA-15393:
----------------------------------------------------
{quote}This one compiles without errors just by omitting the generic type
information: This one compiles without errors just by omitting the generic type
information
{quote}
This seems like a problem that can be resolved - I agree that some of the type
information isn't properly propagated in some places, but I suspect that might
be because the patch was awaiting feedback on its general structure.
{quote}Another source of errors is that positions & offsets are manually
handled now.
{quote}
I am also not a _huge_ fan of this, but we have compromises to make. I don't
think this is particularly error-prone, however, since we already do this a
great deal - it's pretty integral to how our serialization/deserialization
works, so this is not a new category of problem. That's not to say there isn't
room for suggestions that might lead to improvement here, I don't know, but it
doesn't seem at all disqualifying to me.
Unrelatedly, [~bdeggleston], is there a reason you didn't go the whole hog and
just get rid of the {{ByteBuffer}} versions of everything?
> Add byte array backed cells
> ---------------------------
>
> Key: CASSANDRA-15393
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15393
> Project: Cassandra
> Issue Type: Sub-task
> Components: Local/Compaction
> Reporter: Blake Eggleston
> Assignee: Blake Eggleston
> Priority: Normal
> Fix For: 4.0-beta
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We currently materialize all values as on heap byte buffers. Byte buffers
> have a fairly high overhead given how frequently they’re used, and on the
> compaction and local read path we don’t do anything that needs them. Use of
> byte buffer methods only happens on the coordinator. Using cells that are
> backed by byte arrays instead in these situations reduces compaction and read
> garbage up to 22% in many cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
