[
https://issues.apache.org/jira/browse/CASSANDRA-18116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655172#comment-17655172
]
Jordan West commented on CASSANDRA-18116:
-----------------------------------------
Changed javadoc to "@return empty denylist if we do not or cannot find the
data, preserving the old value, otherwise the new value".
Second run of tests here:
[j11|https://app.circleci.com/pipelines/github/jrwest/cassandra/129/workflows/d8db359f-3d98-4ba5-84ab-14083e387a6e]
[j8|https://app.circleci.com/pipelines/github/jrwest/cassandra/129/workflows/94cf9c40-bd35-4983-a787-15b466fbd6df]
> Denylist can load perpetually and too frequently if it fails persistently
> --------------------------------------------------------------------------
>
> Key: CASSANDRA-18116
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18116
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Rate Limiting
> Reporter: Jordan West
> Assignee: Jordan West
> Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
>
> When the denylist fails its initial load it can [return a value of
> null|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/schema/PartitionDenylist.java#L453]
> for a key in the cache. The [BoundedLoadingCache
> implementation|https://github.com/ben-manes/caffeine/blob/master/caffeine/src/main/java/com/github/benmanes/caffeine/cache/BoundedLocalCache.java#L2591-L2615]
> that is used treats null as missing and will end up trying to load the key
> on reads. Besides the performance impact this can also lead to significant
> log spam leading to disk or CPU usage issues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
