[
https://issues.apache.org/jira/browse/CASSANDRA-19448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835466#comment-17835466
]
Brandon Williams edited comment on CASSANDRA-19448 at 4/9/24 3:44 PM:
----------------------------------------------------------------------
I'm sorry that I missed that removing the precision would affect JMX, and I can
see you fixed the [JMXCompatibility
test|https://github.com/apache/cassandra/pull/3238/commits/b0db7522d34d82a67a8d1ef486394c0aee86f7f2].
Unfortunately we can't do it like this, CASSANDRA-8734 exposed these archiver
methods, very likely for some automation. We should deprecate this first,
however in this instance we aren't removing functionality so much as obviating
the need for precision, so any breakage should be minimal. I suggest we leave
precision alone and deprecate it in 4.0 and 4.1 and remove in 5.0 and trunk.
WDYT?
was (Author: brandon.williams):
I'm sorry that I missed that removing the precision would affect JMX, and I can
see you fixed the [JMXCompatibility
test|https://github.com/apache/cassandra/pull/3238/commits/b0db7522d34d82a67a8d1ef486394c0aee86f7f2].
Unfortunately we can't do it like this, CASSANDRA-8734 exposed these archiver
methods, very likely for some automation. We should deprecate this first,
however in this instance we aren't removing functionality so much as obviating
the need for precision, so any breakage should be minimal. I suggest we leave
precision alone in 4.0, deprecate in 4.1 and remove in 5.0 and trunk. WDYT?
> CommitlogArchiver only has granularity to seconds for restore_point_in_time
> ---------------------------------------------------------------------------
>
> Key: CASSANDRA-19448
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19448
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Commit Log
> Reporter: Jeremy Hanna
> Assignee: Maxwell Guo
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Commitlog archiver allows users to backup commitlog files for the purpose of
> doing point in time restores. The [configuration
> file|https://github.com/apache/cassandra/blob/trunk/conf/commitlog_archiving.properties]
> gives an example of down to the seconds granularity but then asks what
> whether the timestamps are microseconds or milliseconds - defaulting to
> microseconds. Because the [CommitLogArchiver uses a second based date
> format|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogArchiver.java#L52],
> if a user specifies to restore at something at a lower granularity like
> milliseconds or microseconds, that means that the it will truncate everything
> after the second and restore to that second. So say you specify a
> restore_point_in_time like this:
> restore_point_in_time=2024:01:18 17:01:01.623392
> it will silently truncate everything after the 01 seconds. So effectively to
> the user, it is missing updates between 01 and 01.623392.
> This appears to be a bug in the intent. We should allow users to specify
> down to the millisecond or even microsecond level. If we allow them to
> specify down to microseconds for the restore point in time, then it may
> internally need to change from a long.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
