[ https://issues.apache.org/jira/browse/CASSANDRA-19600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842897#comment-17842897 ]
Stefan Miklosovic edited comment on CASSANDRA-19600 at 5/2/24 9:21 AM: ----------------------------------------------------------------------- trunk's build seems to be rather flaky. j17 looks fine, j11 is struggling a little bit. I will go over it to be sure it is indeed all just flakes or we had a bad luck with Circle. Otherwise looks like the changes we did have nothing in common with the failed test results, I do not see anything suspicious. [CASSANDRA-19600-trunk|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19600-trunk] {noformat} java17_pre-commit_tests ✓ j17_build 4m 50s ✓ j17_cqlsh_dtests_py311 7m 1s ✓ j17_cqlsh_dtests_py311_vnode 7m 9s ✓ j17_cqlsh_dtests_py38 6m 50s ✓ j17_cqlsh_dtests_py38_vnode 7m 22s ✓ j17_cqlshlib_cython_tests 8m 31s ✓ j17_cqlshlib_tests 6m 45s ✓ j17_dtests 36m 46s ✓ j17_dtests_vnode 35m 7s ✓ j17_unit_tests 14m 6s ✓ j17_utests_latest 13m 44s ✓ j17_utests_oa 13m 51s ✕ j17_dtests_latest 36m 31s configuration_test.TestConfiguration test_change_durable_writes ✕ j17_jvm_dtests 28m 32s org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testEndpointVerificationEnabledIpNotInSAN TIMEOUTED ✕ j17_jvm_dtests_latest_vnode 23m 30s junit.framework.TestSuite org.apache.cassandra.fuzz.harry.integration.model.InJVMTokenAwareExecutorTest TIMEOUTED java17_separate_tests java11_pre-commit_tests ✓ j11_build 8m 27s ✓ j11_cqlsh_dtests_py311 10m 12s ✓ j11_cqlsh_dtests_py311_vnode 9m 24s ✓ j11_cqlsh_dtests_py38 8m 1s ✓ j11_cqlsh_dtests_py38_vnode 8m 20s ✓ j11_cqlshlib_cython_tests 11m 34s ✓ j11_cqlshlib_tests 7m 7s ✓ j11_dtests 41m 45s ✓ j11_dtests_vnode 37m 37s ✓ j11_jvm_dtests 26m 58s ✓ j11_unit_tests 17m 56s ✓ j11_utests_latest 19m 24s ✓ j11_utests_oa 18m 38s ✓ j17_cqlsh_dtests_py311 7m 24s ✓ j17_cqlsh_dtests_py311_vnode 7m 26s ✓ j17_cqlsh_dtests_py38 7m 12s ✓ j17_cqlsh_dtests_py38_vnode 7m 8s ✓ j17_cqlshlib_cython_tests 7m 39s ✓ j17_cqlshlib_tests 8m 45s ✓ j17_dtests_vnode 36m 59s ✓ j17_unit_tests 13m 34s ✓ j17_utests_latest 18m 34s ✓ j17_utests_oa 14m 45s ✕ j11_dtests_latest 41m 59s configuration_test.TestConfiguration test_change_durable_writes topology_test.TestTopology test_resumable_decommission ✕ j11_jvm_dtests_latest_vnode 24m 24s org.apache.cassandra.distributed.test.tcm.SplitBrainTest testSplitBrainStartup TIMEOUTED ✕ j11_simulator_dtests 10m 51s org.apache.cassandra.simulator.test.HarrySimulatorTest test org.apache.cassandra.simulator.test.ShortPaxosSimulationTest simulationTest ✕ j11_utests_system_keyspace_directory 13m 55s org.apache.cassandra.transport.CQLUserAuditTest queryInsert org.apache.cassandra.transport.CQLUserAuditTest prepareStmt org.apache.cassandra.transport.CQLUserAuditTest loginSuccessfulTest org.apache.cassandra.transport.CQLUserAuditTest queryBatch org.apache.cassandra.transport.CQLUserAuditTest querySimpleSelect ✕ j17_dtests 40m 21s sslnodetonode_test.TestNodeToNodeSSLEncryption test_ssl_client_auth_required_succeed transient_replication_test.TestTransientReplication test_srp ttl_test.TestRecoverNegativeExpirationDate test_recover_negative_expiration_date_sstables_with_scrub user_functions_test.TestUserFunctions test_default_aggregate write_failures_test.TestWriteFailures test_mutation_quorum sslnodetonode_test.TestNodeToNodeSSLEncryption test_ssl_wrong_hostname_no_validation transient_replication_test.TestTransientReplication test_transient_full_merge_read_with_delete_transient_coordinator ttl_test.TestTTL test_collection_set_ttl write_failures_test.TestWriteFailures test_mutation_v4 transient_replication_test.TestTransientReplicationRepairLegacyStreaming test_optimized_primary_range_repair_with_lcs transient_replication_ring_test.TestTransientReplicationRing test_decommission ✕ j17_dtests_latest 35m 35s configuration_test.TestConfiguration test_change_durable_writes ✕ j17_jvm_dtests 22m 22s org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testOptionalMtlsModeDoNotAllowNonSSLConnections org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testEndpointVerificationEnabledIpNotInSAN org.apache.cassandra.distributed.test.guardrails.IntersectFilteringQueryTest shouldNotWarnOrFailOnIndexQuery ✕ j17_jvm_dtests_latest_vnode 22m 41s org.apache.cassandra.distributed.test.tcm.SplitBrainTest testSplitBrainStartup TIMEOUTED java11_separate_tests {noformat} [java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4265/workflows/0a2cb986-73fb-44c6-8c91-a71226f0b8d3] [java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4265/workflows/6251fd87-095d-47ab-a853-667e9907f7a3] [java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4265/workflows/1dd2eb8e-60bf-4643-9045-634bf99a7b42] [java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4265/workflows/c5076169-f3eb-4a8b-91c3-5bd0cbc719f9] EDIT: CQLUserAuditTest is CASSANDRA-19165 was (Author: smiklosovic): trunk's build seems to be rather flaky. j17 looks fine, j11 is struggling a little bit. I will go over it to be sure it is indeed all just flakes or we had a bad luck with Circle. Otherwise looks like the changes we did have nothing in common with the failed test results, I do not see anything suspicious. [CASSANDRA-19600-trunk|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19600-trunk] {noformat} java17_pre-commit_tests ✓ j17_build 4m 50s ✓ j17_cqlsh_dtests_py311 7m 1s ✓ j17_cqlsh_dtests_py311_vnode 7m 9s ✓ j17_cqlsh_dtests_py38 6m 50s ✓ j17_cqlsh_dtests_py38_vnode 7m 22s ✓ j17_cqlshlib_cython_tests 8m 31s ✓ j17_cqlshlib_tests 6m 45s ✓ j17_dtests 36m 46s ✓ j17_dtests_vnode 35m 7s ✓ j17_unit_tests 14m 6s ✓ j17_utests_latest 13m 44s ✓ j17_utests_oa 13m 51s ✕ j17_dtests_latest 36m 31s configuration_test.TestConfiguration test_change_durable_writes ✕ j17_jvm_dtests 28m 32s org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testEndpointVerificationEnabledIpNotInSAN TIMEOUTED ✕ j17_jvm_dtests_latest_vnode 23m 30s junit.framework.TestSuite org.apache.cassandra.fuzz.harry.integration.model.InJVMTokenAwareExecutorTest TIMEOUTED java17_separate_tests java11_pre-commit_tests ✓ j11_build 8m 27s ✓ j11_cqlsh_dtests_py311 10m 12s ✓ j11_cqlsh_dtests_py311_vnode 9m 24s ✓ j11_cqlsh_dtests_py38 8m 1s ✓ j11_cqlsh_dtests_py38_vnode 8m 20s ✓ j11_cqlshlib_cython_tests 11m 34s ✓ j11_cqlshlib_tests 7m 7s ✓ j11_dtests 41m 45s ✓ j11_dtests_vnode 37m 37s ✓ j11_jvm_dtests 26m 58s ✓ j11_unit_tests 17m 56s ✓ j11_utests_latest 19m 24s ✓ j11_utests_oa 18m 38s ✓ j17_cqlsh_dtests_py311 7m 24s ✓ j17_cqlsh_dtests_py311_vnode 7m 26s ✓ j17_cqlsh_dtests_py38 7m 12s ✓ j17_cqlsh_dtests_py38_vnode 7m 8s ✓ j17_cqlshlib_cython_tests 7m 39s ✓ j17_cqlshlib_tests 8m 45s ✓ j17_dtests_vnode 36m 59s ✓ j17_unit_tests 13m 34s ✓ j17_utests_latest 18m 34s ✓ j17_utests_oa 14m 45s ✕ j11_dtests_latest 41m 59s configuration_test.TestConfiguration test_change_durable_writes topology_test.TestTopology test_resumable_decommission ✕ j11_jvm_dtests_latest_vnode 24m 24s org.apache.cassandra.distributed.test.tcm.SplitBrainTest testSplitBrainStartup TIMEOUTED ✕ j11_simulator_dtests 10m 51s org.apache.cassandra.simulator.test.HarrySimulatorTest test org.apache.cassandra.simulator.test.ShortPaxosSimulationTest simulationTest ✕ j11_utests_system_keyspace_directory 13m 55s org.apache.cassandra.transport.CQLUserAuditTest queryInsert org.apache.cassandra.transport.CQLUserAuditTest prepareStmt org.apache.cassandra.transport.CQLUserAuditTest loginSuccessfulTest org.apache.cassandra.transport.CQLUserAuditTest queryBatch org.apache.cassandra.transport.CQLUserAuditTest querySimpleSelect ✕ j17_dtests 40m 21s sslnodetonode_test.TestNodeToNodeSSLEncryption test_ssl_client_auth_required_succeed transient_replication_test.TestTransientReplication test_srp ttl_test.TestRecoverNegativeExpirationDate test_recover_negative_expiration_date_sstables_with_scrub user_functions_test.TestUserFunctions test_default_aggregate write_failures_test.TestWriteFailures test_mutation_quorum sslnodetonode_test.TestNodeToNodeSSLEncryption test_ssl_wrong_hostname_no_validation transient_replication_test.TestTransientReplication test_transient_full_merge_read_with_delete_transient_coordinator ttl_test.TestTTL test_collection_set_ttl write_failures_test.TestWriteFailures test_mutation_v4 transient_replication_test.TestTransientReplicationRepairLegacyStreaming test_optimized_primary_range_repair_with_lcs transient_replication_ring_test.TestTransientReplicationRing test_decommission ✕ j17_dtests_latest 35m 35s configuration_test.TestConfiguration test_change_durable_writes ✕ j17_jvm_dtests 22m 22s org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testOptionalMtlsModeDoNotAllowNonSSLConnections org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testEndpointVerificationEnabledIpNotInSAN org.apache.cassandra.distributed.test.guardrails.IntersectFilteringQueryTest shouldNotWarnOrFailOnIndexQuery ✕ j17_jvm_dtests_latest_vnode 22m 41s org.apache.cassandra.distributed.test.tcm.SplitBrainTest testSplitBrainStartup TIMEOUTED java11_separate_tests {noformat} [java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4265/workflows/0a2cb986-73fb-44c6-8c91-a71226f0b8d3] [java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4265/workflows/6251fd87-095d-47ab-a853-667e9907f7a3] [java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4265/workflows/1dd2eb8e-60bf-4643-9045-634bf99a7b42] [java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4265/workflows/c5076169-f3eb-4a8b-91c3-5bd0cbc719f9] > Resolve the oldest hints just from descriptors and current writer if available > ------------------------------------------------------------------------------ > > Key: CASSANDRA-19600 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19600 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core > Reporter: Stefan Miklosovic > Assignee: Stefan Miklosovic > Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > We should not resolve hints from buffers as these are just very short-lived / > transient data structures and resolving "the oldest hints" from buffers too > just does not make sense when we should just look into descriptors and > current writer's descriptor at most. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org