[ 
https://issues.apache.org/jira/browse/CASSANDRA-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843767#comment-17843767
 ] 

Maxim Muzafarov commented on CASSANDRA-19619:
---------------------------------------------

[~e.dimitrova] yes, we've agreed with [~maedhroz] to include these changes into 
the 5.0. The changes should be pretty straightforward, but verification is 
needed. I'm trying to run everything locally so far as I'm exhausted my OS 
credits on CircleCi. 

> Enforce contract for internal metrics naming
> --------------------------------------------
>
>                 Key: CASSANDRA-19619
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19619
>             Project: Cassandra
>          Issue Type: Task
>          Components: Observability/Metrics
>            Reporter: Maxim Muzafarov
>            Assignee: Maxim Muzafarov
>            Priority: Normal
>             Fix For: 5.0-rc, 5.0.x, 5.x
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Metrics have their internal representation which uniquely identifies a 
> particular metric name. The name is formed as {{<metric group>.<metric 
> type>.<metric name>.<metric scope>}}. For some metrics, the scope includes a 
> metric name that is not necessary for uniqueness, this can be simplified.
> For example,
> {code}
> // AS IS
> org.apache.cassandra.metrics.StorageAttachedIndex.BalancedTreeIntersectionEarlyExits.my_keyspace.my_table.ColumnQueryMetrics.BalancedTreeIntersectionEarlyExits
> // TO BE
> org.apache.cassandra.metrics.StorageAttachedIndex.BalancedTreeIntersectionEarlyExits.my_keyspace.my_table.ColumnQueryMetrics
> {code}
> The metrics are filtered based on knowledge of how they are formatted, so 
> having a metric scope without a built-in metric name also simplifies the way 
> we filter metrics.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to