[
https://issues.apache.org/jira/browse/CASSANDRA-19341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844300#comment-17844300
]
Ekaterina Dimitrova edited comment on CASSANDRA-19341 at 5/7/24 1:47 PM:
-------------------------------------------------------------------------
[~smiklosovic], thank you for the ping and sorry for the noise, there were a
few empty lines removed by mistake in that test.
Ninja fixed to https://github.com/apache/cassandra-dtest.git
6dd7def9..1f81e1c9 trunk -> trunk
Tested the fixed cassandra-dtest trunk locally with all Cassandra branches 4.0+
was (Author: e.dimitrova):
[~smiklosovic], thank you for the ping and sorry for the noise, there were a
few empty lines removed by mistake in that test.
Ninja fixed to https://github.com/apache/cassandra-dtest.git
6dd7def9..1f81e1c9 trunk -> trunk
Tested the fixed branch locally on all branches 4.0+
> Relation and Restriction hierarchies are too complex and error prone
> --------------------------------------------------------------------
>
> Key: CASSANDRA-19341
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19341
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
> Reporter: Benjamin Lerer
> Assignee: Benjamin Lerer
> Priority: Normal
> Fix For: 5.1
>
> Time Spent: 32h 40m
> Remaining Estimate: 0h
>
> The {{Relation}} and {{Restriction}} hierarchy have been designed when C* was
> only supporting a limited amount of operators and columns expressions (single
> column, multi-column and token expressions). Over time they have grown in
> complexity making the code harder to understand and modify and error prone.
> Their design is also resulting in unnecessary limitations that could be
> easily lifted, like the ability to accept different predicates on the same
> column.
> Today adding a new operator requires the addition of a lot of glue code and
> surgical changes accross the CQL layer. Making patch for features such as
> CASSANDRA-18584 much complex than it should be.
> The goal of this ticket is to simplify the {{Relation}} and {{Restriction}}
> hierarchies and modify operator class so that adding new operators requires
> only changes to the {{Operator}} class and ANTLR file.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
