adutra commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1595217254
##########
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##########
@@ -52,20 +68,23 @@ default void onSuccess(
* @param executionProfile the execution profile of this request.
* @param node the node that returned the successful response.
* @param requestLogPrefix the dedicated log prefix for this request
+ * @param executionInfo the execution info containing the results of this
request
*/
default void onSuccess(
@NonNull Request request,
long latencyNanos,
@NonNull DriverExecutionProfile executionProfile,
@NonNull Node node,
- @NonNull String requestLogPrefix) {
- // If client doesn't override onSuccess with requestLogPrefix delegate
call to the old method
- onSuccess(request, latencyNanos, executionProfile, node);
+ @NonNull String requestLogPrefix,
Review Comment:
Small request: would it be possible to keep the log prefix as the _last_
parameter? This has been kind of a tacit convention so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
