[
https://issues.apache.org/jira/browse/CASSANDRA-19645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847676#comment-17847676
]
Stefan Miklosovic edited comment on CASSANDRA-19645 at 5/19/24 12:54 PM:
-------------------------------------------------------------------------
Looks good but just saying that when "sequence" is MultiStepOperation, which is
abstract class, then log message in GossiperHelper where "toString" is
implicitly called on sequence will rely on overridden toString method in
extended classes of MultiStepOperation. In other words, if somebody creates new
MultiStepOperation and forgets to override toString in it, the the default one
will be used which is pretty much non-telling.
was (Author: smiklosovic):
Looks good but just saying that when "sequence" is MultiStepOperation, which is
abstract class, then log the message in GossiperHelper where "toString" is
implicitly called on sequence will rely on overridden toString method in
extended classes of MultiStepOperation. In other words, if somebody creates new
MultiStepOperation and forgets to override toString in it, the the default one
will be used which is pretty much non-telling.
> Mismatch of number of args of String.format() in three classes
> --------------------------------------------------------------
>
> Key: CASSANDRA-19645
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19645
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
> Reporter: Dmitrii Kriukov
> Assignee: Dmitrii Kriukov
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Affected classes:
> GossipHelper lines 196-197
> SchemaGenerators line 488
> StorageService line 1087
> I'm goind to provide a PR
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
