[ 
https://issues.apache.org/jira/browse/CASSANDRA-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847768#comment-17847768
 ] 

Brad Schoening commented on CASSANDRA-19450:
--------------------------------------------

[~smiklosovic] if CASSANDRA-19498 succeeded with dtests, than I would believe 
something in this PR is causing the issue.  

Except for changing a Warning msg from stdout to stderr all of the changes in 
this PR are to the 'test' subdirectory for pytest and pytest framework.  I have 
reverted that change to cqlshmain.py.

I couldn't not see any use of pylib/cqlshlib/test/run_cqlsh.py & CqlshRunner in 
dtests, instead dtests appears to define it's own run_cqlsh() method.  I'm 
presuming there no dependency between dtests and pylib/cqlshlib/test.

If this doesn't work, than we can go with just the pycodestyle changes and I'll 
revert run_cqlsh.py.

> Hygiene updates for warnings and pytests
> ----------------------------------------
>
>                 Key: CASSANDRA-19450
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19450
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL/Interpreter
>            Reporter: Brad Schoening
>            Assignee: Brad Schoening
>            Priority: Low
>             Fix For: 5.x
>
>
>  
>  * Update 'Warning' message to write to stderr
>  * -Replace TimeoutError Exception with builtin (since Python 3.3)-
>  * -Remove re.pattern_type (removed since Python 3.7)-
>  * Fix mutable arg [] in read_until()
>  * Remove redirect of stderr to stdout in pytest fixture with tty=false; 
> Deprecation warnings can otherwise fail unit tests when stdout & stderr 
> output is combined.
>  * Fix several pycodestyle issues



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to