[ 
https://issues.apache.org/jira/browse/CASSANDRA-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470087#comment-13470087
 ] 

Sylvain Lebresne commented on CASSANDRA-4351:
---------------------------------------------

Committed 0001 but holding this open a little long to see if we decide 
something on the 2nd part.

bq. what if instead we change LongToken to/fromString to hex-encode with a 
constant width, the way CASSANDRA-4550 wanted? Of course then we'd need to 
switch it to unsigned comparison

That's not a bad idea (since we have no backward compatibility problem) so why 
not (and switching to unsigned comparison is probably not a big deal (though we 
do have to be careful about the fact that the minimum token shouldn't be a 
valid token, so tokens value will have to be in [1, 2^64-1])). That being said, 
I'm not sure about the "instead" in the sentence above. Was that to be 
understood as "in addition" to 0002?
                
> Consider storing more informations on peers in system tables 
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-4351
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4351
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 1.2.0 beta 2
>
>         Attachments: 0001-4351.txt, 0002-Save-tokens-as-strings.txt
>
>
> Currently, the only thing we keep in system tables about other peers is their 
> token and IP addresses. We should probably also record the new ring_id, but 
> since CASSANDRA-4018 makes system table easily queriable, may it could be 
> worth adding some more information (basically most of what we gossip could be 
> a candidate (schema UUID, status, C* version, ...)) as a simple way to expose 
> the ring state to users (even if it's just a "view" of the ring state from 
> one specific node I believe it's still nice).
> Of course that means storing information that may not be absolutely needed by 
> the server, but I'm not sure there is much harm to that.
> Note that doing this cleanly may require changing the schema of current 
> system tables but as long as we do that in the 1.2 timeframe it's ok (since 
> the concerned system table 'local' and 'peers' are news anyway).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to