[ 
https://issues.apache.org/jira/browse/CASSANDRA-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939449#comment-13939449
 ] 

Piotr Kołaczkowski commented on CASSANDRA-6311:
-----------------------------------------------

{noformat}
                if (origHost != null)
+                {
+                    return Collections.singletonList(origHost).iterator();
+                }
+                else
+                {
+                    return liveRemoteHosts.iterator();
+                }
{noformat}

This creates a race condition, if the origHost goes down immediately after 
returning from this method, the list of hosts to try will be empty and the 
query will fail. In the first branch, you should return origHost *and* 
liveRemoteHosts.

> Add CqlRecordReader to take advantage of native CQL pagination
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-6311
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6311
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Hadoop
>            Reporter: Alex Liu
>            Assignee: Alex Liu
>             Fix For: 2.0.7
>
>         Attachments: 6311-v3-2.0-branch.txt, 6311-v4.txt, 
> 6311-v5-2.0-branch.txt, 6311-v6-2.0-branch.txt, 6311-v7.txt, 6311-v8.txt, 
> 6331-2.0-branch.txt, 6331-v2-2.0-branch.txt
>
>
> Since the latest Cql pagination is done and it should be more efficient, so 
> we need update CqlPagingRecordReader to use it instead of the custom thrift 
> paging.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to