Repository: spark
Updated Branches:
  refs/heads/master a5fed3435 -> ad6b169de


[Spark-5889] Remove pid file after stopping service.

Currently the pid file is not deleted, and potentially may cause some problem 
after service is stopped. The fix remove the pid file after service stopped.

Author: Zhan Zhang <zhaz...@gmail.com>

Closes #4676 from zhzhan/spark-5889 and squashes the following commits:

eb01be1 [Zhan Zhang] solve review comments
b4c009e [Zhan Zhang] solve review comments
018110a [Zhan Zhang] spark-5889: remove pid file after stopping service
088d2a2 [Zhan Zhang] squash all commits
c1f1fa5 [Zhan Zhang] test


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/ad6b169d
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/ad6b169d
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/ad6b169d

Branch: refs/heads/master
Commit: ad6b169dee84df175b51933b7a3ad7f0bbc52cf3
Parents: a5fed34
Author: Zhan Zhang <zhaz...@gmail.com>
Authored: Thu Feb 19 23:13:02 2015 +0000
Committer: Sean Owen <so...@cloudera.com>
Committed: Thu Feb 19 23:13:02 2015 +0000

----------------------------------------------------------------------
 sbin/spark-daemon.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/ad6b169d/sbin/spark-daemon.sh
----------------------------------------------------------------------
diff --git a/sbin/spark-daemon.sh b/sbin/spark-daemon.sh
index e1bcc7d..5e812a1 100755
--- a/sbin/spark-daemon.sh
+++ b/sbin/spark-daemon.sh
@@ -168,7 +168,7 @@ case $option in
       TARGET_ID="$(cat "$pid")"
       if [[ $(ps -p "$TARGET_ID" -o comm=) =~ "java" ]]; then
         echo "stopping $command"
-        kill "$TARGET_ID"
+        kill "$TARGET_ID" && rm -f "$pid"
       else
         echo "no $command to stop"
       fi


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to