Repository: spark Updated Branches: refs/heads/branch-1.6 bea91a9e9 -> 8a1bd5834
[SPARK-13760][SQL] Fix BigDecimal constructor for FloatType ## What changes were proposed in this pull request? A very minor change for using `BigDecimal.decimal(f: Float)` instead of `BigDecimal(f: float)`. The latter is deprecated and can result in inconsistencies due to an implicit conversion to `Double`. ## How was this patch tested? N/A cc yhuai Author: Sameer Agarwal <sam...@databricks.com> Closes #11597 from sameeragarwal/bigdecimal. (cherry picked from commit 926e9c45a21c5b71ef0832d63b8dae7d4f3d8826) Signed-off-by: Yin Huai <yh...@databricks.com> Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/8a1bd583 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/8a1bd583 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/8a1bd583 Branch: refs/heads/branch-1.6 Commit: 8a1bd5834cec61a882c54fdf56385c76b221cb4f Parents: bea91a9 Author: Sameer Agarwal <sam...@databricks.com> Authored: Wed Mar 9 18:16:29 2016 -0800 Committer: Yin Huai <yh...@databricks.com> Committed: Wed Mar 9 18:17:16 2016 -0800 ---------------------------------------------------------------------- .../apache/spark/sql/catalyst/expressions/mathExpressions.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/8a1bd583/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala ---------------------------------------------------------------------- diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala index 28f616f..4825bd2 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala @@ -739,7 +739,7 @@ case class Round(child: Expression, scale: Expression) if (f.isNaN || f.isInfinite) { f } else { - BigDecimal(f).setScale(_scale, HALF_UP).toFloat + BigDecimal.decimal(f).setScale(_scale, HALF_UP).toFloat } case DoubleType => val d = input1.asInstanceOf[Double] --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
