Repository: spark Updated Branches: refs/heads/master fb6a92275 -> 6f41c593b
[SPARK-22690][ML] Imputer inherit HasOutputCols ## What changes were proposed in this pull request? make `Imputer` inherit `HasOutputCols` ## How was this patch tested? existing tests Author: Zheng RuiFeng <ruife...@foxmail.com> Closes #19889 from zhengruifeng/using_HasOutputCols. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/6f41c593 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/6f41c593 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/6f41c593 Branch: refs/heads/master Commit: 6f41c593bbefa946d13b62ecf4e85074fd3c1541 Parents: fb6a922 Author: Zheng RuiFeng <ruife...@foxmail.com> Authored: Wed Dec 6 08:27:17 2017 -0800 Committer: Holden Karau <holdenka...@google.com> Committed: Wed Dec 6 08:27:17 2017 -0800 ---------------------------------------------------------------------- .../scala/org/apache/spark/ml/feature/Imputer.scala | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/6f41c593/mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala ---------------------------------------------------------------------- diff --git a/mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala b/mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala index 4663f16..730ee9f 100644 --- a/mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala +++ b/mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala @@ -23,7 +23,7 @@ import org.apache.spark.SparkException import org.apache.spark.annotation.{Experimental, Since} import org.apache.spark.ml.{Estimator, Model} import org.apache.spark.ml.param._ -import org.apache.spark.ml.param.shared.HasInputCols +import org.apache.spark.ml.param.shared.{HasInputCols, HasOutputCols} import org.apache.spark.ml.util._ import org.apache.spark.sql.{DataFrame, Dataset, Row} import org.apache.spark.sql.functions._ @@ -32,7 +32,7 @@ import org.apache.spark.sql.types._ /** * Params for [[Imputer]] and [[ImputerModel]]. */ -private[feature] trait ImputerParams extends Params with HasInputCols { +private[feature] trait ImputerParams extends Params with HasInputCols with HasOutputCols { /** * The imputation strategy. Currently only "mean" and "median" are supported. @@ -63,16 +63,6 @@ private[feature] trait ImputerParams extends Params with HasInputCols { /** @group getParam */ def getMissingValue: Double = $(missingValue) - /** - * Param for output column names. - * @group param - */ - final val outputCols: StringArrayParam = new StringArrayParam(this, "outputCols", - "output column names") - - /** @group getParam */ - final def getOutputCols: Array[String] = $(outputCols) - /** Validates and transforms the input schema. */ protected def validateAndTransformSchema(schema: StructType): StructType = { require($(inputCols).length == $(inputCols).distinct.length, s"inputCols contains" + --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
