This is an automated email from the ASF dual-hosted git repository. srowen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new 8f6af64 [SPARK-37056][CORE] Remove unused code in HistoryServer'ss unit test 8f6af64 is described below commit 8f6af642bc5c48db04c8c99b5897ec052c1ae15e Author: Angerszhuuuu <angers....@gmail.com> AuthorDate: Sat Oct 23 10:02:19 2021 -0500 [SPARK-37056][CORE] Remove unused code in HistoryServer'ss unit test ### What changes were proposed in this pull request? Remove unused code in HistoryServer 's unit test. Since `HistoryServer.initialize()` is called when construct the object, we should remove the call in unit test. ### Why are the changes needed? Fix ut code ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existed UT Closes #34327 from AngersZhuuuu/SPARK-37056. Authored-by: Angerszhuuuu <angers....@gmail.com> Signed-off-by: Sean Owen <sro...@gmail.com> --- .../test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala | 2 -- .../apache/spark/deploy/history/RealBrowserUIHistoryServerSuite.scala | 1 - 2 files changed, 3 deletions(-) diff --git a/core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala b/core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala index 71ab9e7..10900dd 100644 --- a/core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala +++ b/core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala @@ -91,7 +91,6 @@ class HistoryServerSuite extends SparkFunSuite with BeforeAndAfter with Matchers val securityManager = HistoryServer.createSecurityManager(conf) server = new HistoryServer(conf, provider, securityManager, 18080) - server.initialize() server.bind() provider.start() port = server.boundPort @@ -413,7 +412,6 @@ class HistoryServerSuite extends SparkFunSuite with BeforeAndAfter with Matchers } server = new HistoryServer(myConf, provider, securityManager, 0) - server.initialize() server.bind() provider.start() val port = server.boundPort diff --git a/core/src/test/scala/org/apache/spark/deploy/history/RealBrowserUIHistoryServerSuite.scala b/core/src/test/scala/org/apache/spark/deploy/history/RealBrowserUIHistoryServerSuite.scala index 4a5c34f..ba8bd8d 100644 --- a/core/src/test/scala/org/apache/spark/deploy/history/RealBrowserUIHistoryServerSuite.scala +++ b/core/src/test/scala/org/apache/spark/deploy/history/RealBrowserUIHistoryServerSuite.scala @@ -87,7 +87,6 @@ abstract class RealBrowserUIHistoryServerSuite(val driverProp: String) val securityManager = HistoryServer.createSecurityManager(conf) server = new HistoryServer(conf, provider, securityManager, 18080) - server.initialize() server.bind() provider.start() port = server.boundPort --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org