This is an automated email from the ASF dual-hosted git repository.

srowen pushed a commit to branch branch-3.4
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.4 by this push:
     new 807abf9c53e [SPARK-43004][CORE] Fix typo in ResourceRequest.equals()
807abf9c53e is described below

commit 807abf9c53ee8c1c7ef69646ebd8a266f60d5580
Author: thyecust <t...@mail.ecust.edu.cn>
AuthorDate: Sun Apr 2 22:36:04 2023 -0500

    [SPARK-43004][CORE] Fix typo in ResourceRequest.equals()
    
    vendor == vendor is always true, this is likely to be a typo.
    
    ### What changes were proposed in this pull request?
    
    fix `vendor == vendor` with `that.vendor == vendor`, and `discoveryScript 
== discoveryScript` with `that.discoveryScript == discoveryScript`
    
    ### Why are the changes needed?
    
    vendor == vendor is always true, this is likely to be a typo.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    By GitHub Actions.
    
    Closes #40622 from thyecust/patch-4.
    
    Authored-by: thyecust <t...@mail.ecust.edu.cn>
    Signed-off-by: Sean Owen <sro...@gmail.com>
    (cherry picked from commit 52c000ece27c9ef34969a7fb252714588f395926)
    Signed-off-by: Sean Owen <sro...@gmail.com>
---
 core/src/main/scala/org/apache/spark/resource/ResourceUtils.scala | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/src/main/scala/org/apache/spark/resource/ResourceUtils.scala 
b/core/src/main/scala/org/apache/spark/resource/ResourceUtils.scala
index 0e18ecf0e51..6e294397a3c 100644
--- a/core/src/main/scala/org/apache/spark/resource/ResourceUtils.scala
+++ b/core/src/main/scala/org/apache/spark/resource/ResourceUtils.scala
@@ -87,8 +87,8 @@ class ResourceRequest(
     obj match {
       case that: ResourceRequest =>
         that.getClass == this.getClass &&
-          that.id == id && that.amount == amount && discoveryScript == 
discoveryScript &&
-          vendor == vendor
+          that.id == id && that.amount == amount && that.discoveryScript == 
discoveryScript &&
+          that.vendor == vendor
       case _ =>
         false
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to