[spark] branch branch-3.4 updated: [SPARK-43337][UI][3.4] Asc/desc arrow icons for sorting column does not get displayed in the table column

[srowen]

This is an automated email from the ASF dual-hosted git repository.

srowen pushed a commit to branch branch-3.4
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.4 by this push:
     new e04025e359f [SPARK-43337][UI][3.4] Asc/desc arrow icons for sorting 
column does not get displayed in the table column
e04025e359f is described below

commit e04025e359fe3d8bbaa7b695b491319f050adeb1
Author: Maytas Monsereenusorn <mayt...@apache.org>
AuthorDate: Fri May 5 10:25:46 2023 -0500

    [SPARK-43337][UI][3.4] Asc/desc arrow icons for sorting column does not get 
displayed in the table column
    
    ### What changes were proposed in this pull request? Remove css 
`!important` tag for asc/desc arrow icons in jquery.dataTables.1.10.25.min.css
    
    ### Why are the changes needed?
    Upgrading to DataTables 1.10.25 broke asc/desc arrow icons for sorting 
column. The sorting icon is not displayed when the column is clicked to sort by 
asc/desc. This is because the new DataTables 1.10.25's 
jquery.dataTables.1.10.25.min.css file added `!important` rule preventing the 
override set in webui-dataTables.css
    
    ### Does this PR introduce _any_ user-facing change? No.
    
    ### How was this patch tested?
    Manual test.
    
    
![image](https://user-images.githubusercontent.com/52679095/236394863-e0004e7b-5173-495a-af23-32c1343e0ee6.png)
    
![image](https://user-images.githubusercontent.com/52679095/236394879-db0e5e0e-f6b3-48c3-9c79-694dd9abcb76.png)
    
    Closes #41061 from maytasm/fix-arrow-4.
    
    Authored-by: Maytas Monsereenusorn <mayt...@apache.org>
    Signed-off-by: Sean Owen <sro...@gmail.com>
---
 .../org/apache/spark/ui/static/jquery.dataTables.1.10.25.min.css        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/core/src/main/resources/org/apache/spark/ui/static/jquery.dataTables.1.10.25.min.css
 
b/core/src/main/resources/org/apache/spark/ui/static/jquery.dataTables.1.10.25.min.css
index 6e60559741c..4df81e13a75 100644
--- 
a/core/src/main/resources/org/apache/spark/ui/static/jquery.dataTables.1.10.25.min.css
+++ 
b/core/src/main/resources/org/apache/spark/ui/static/jquery.dataTables.1.10.25.min.css
@@ -1 +1 @@
-table.dataTable{width:100%;margin:0 
auto;clear:both;border-collapse:separate;border-spacing:0}table.dataTable thead 
th,table.dataTable tfoot th{font-weight:bold}table.dataTable thead 
th,table.dataTable thead td{padding:10px 18px;border-bottom:1px solid 
#111}table.dataTable thead th:active,table.dataTable thead 
td:active{outline:none}table.dataTable tfoot th,table.dataTable tfoot 
td{padding:10px 18px 6px 18px;border-top:1px solid #111}table.dataTable thead 
.sorting,table.dataTable thead . [...]
\ No newline at end of file
+table.dataTable{width:100%;margin:0 
auto;clear:both;border-collapse:separate;border-spacing:0}table.dataTable thead 
th,table.dataTable tfoot th{font-weight:bold}table.dataTable thead 
th,table.dataTable thead td{padding:10px 18px;border-bottom:1px solid 
#111}table.dataTable thead th:active,table.dataTable thead 
td:active{outline:none}table.dataTable tfoot th,table.dataTable tfoot 
td{padding:10px 18px 6px 18px;border-top:1px solid #111}table.dataTable thead 
.sorting,table.dataTable thead . [...]
\ No newline at end of file


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org