This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 5446f548bbc8 [SPARK-45231][INFRA] Remove unrecognized and meaningless
command about `Ammonite` from the GA testing workflow
5446f548bbc8 is described below
commit 5446f548bbc8a93414f1c773a8daf714b57b7d1a
Author: panbingkun <pbk1...@gmail.com>
AuthorDate: Thu Oct 5 13:13:43 2023 -0400
[SPARK-45231][INFRA] Remove unrecognized and meaningless command about
`Ammonite` from the GA testing workflow
### What changes were proposed in this pull request?
The pr aims to remove unrecognized and meaningless command about `amm` from
the GA testing workflow.
### Why are the changes needed?
- When I observed GA's logs, I found the following logs:
```
Run # Fix for TTY related issues when launching the Ammonite REPL in tests.
sh: 1: amm: not found
```
eg:
https://github.com/apache/spark/actions/runs/6243934856/job/16950117287#step:10:21
https://github.com/panbingkun/spark/actions/runs/6232228999/job/16924063382#step:10:22
Obviously, `amm` did not recognize it. Through trial and error, it was
found that the above command do not need to be executed in our GA.
- Enhance maintainability and reduce misunderstandings.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #42993 from panbingkun/remove_amm_test.
Authored-by: panbingkun <pbk1...@gmail.com>
Signed-off-by: Herman van Hovell <her...@databricks.com>
---
.github/workflows/build_and_test.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/build_and_test.yml
b/.github/workflows/build_and_test.yml
index 669cd76bd72f..5dce503a1799 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -261,7 +261,7 @@ jobs:
shell: 'script -q -e -c "bash {0}"'
run: |
# Fix for TTY related issues when launching the Ammonite REPL in tests.
- export TERM=vt100 && script -qfc 'echo exit | amm -s' && rm typescript
+ export TERM=vt100
# Hive "other tests" test needs larger metaspace size based on
experiment.
if [[ "$MODULES_TO_TEST" == "hive" ]] && [[ "$EXCLUDED_TAGS" ==
"org.apache.spark.tags.SlowHiveTest" ]]; then export METASPACE_SIZE=2g; fi
export SERIAL_SBT_TESTS=1
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
