This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new e331de06dd05 [MINOR][CORE][SQL] Clean up expired comments: `Note: this
class supports Scala 2.13. A parallel source tree has a 2.12 implementation.`
e331de06dd05 is described below
commit e331de06dd0526761c804b32640e3471ce772d38
Author: yangjie01 <yangji...@baidu.com>
AuthorDate: Wed Nov 8 08:26:23 2023 -0800
[MINOR][CORE][SQL] Clean up expired comments: `Note: this class supports
Scala 2.13. A parallel source tree has a 2.12 implementation.`
### What changes were proposed in this pull request?
This pr just clean up expired comments: `Note: this class supports Scala
2.13. A parallel source tree has a 2.12 implementation.`
### Why are the changes needed?
Apache Spark 4.0 only support Scala 2.13, so these comments are no longer
needed
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No testing required
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #43718 from LuciferYang/minor-comments.
Lead-authored-by: yangjie01 <yangji...@baidu.com>
Co-authored-by: YangJie <yangji...@baidu.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
core/src/main/scala/org/apache/spark/util/BoundedPriorityQueue.scala | 2 --
.../scala/org/apache/spark/sql/catalyst/util/CaseInsensitiveMap.scala | 2 --
.../scala/org/apache/spark/sql/catalyst/expressions/AttributeMap.scala | 2 --
.../scala/org/apache/spark/sql/execution/streaming/StreamProgress.scala | 2 --
4 files changed, 8 deletions(-)
diff --git
a/core/src/main/scala/org/apache/spark/util/BoundedPriorityQueue.scala
b/core/src/main/scala/org/apache/spark/util/BoundedPriorityQueue.scala
index ccb4d2063ff3..9fed2373ea55 100644
--- a/core/src/main/scala/org/apache/spark/util/BoundedPriorityQueue.scala
+++ b/core/src/main/scala/org/apache/spark/util/BoundedPriorityQueue.scala
@@ -31,8 +31,6 @@ import scala.jdk.CollectionConverters._
private[spark] class BoundedPriorityQueue[A](maxSize: Int)(implicit ord:
Ordering[A])
extends Iterable[A] with Growable[A] with Serializable {
- // Note: this class supports Scala 2.13. A parallel source tree has a 2.12
implementation.
-
private val underlying = new JPriorityQueue[A](maxSize, ord)
override def iterator: Iterator[A] = underlying.iterator.asScala
diff --git
a/sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/CaseInsensitiveMap.scala
b/sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/CaseInsensitiveMap.scala
index e18a01810d2e..640304efce4b 100644
---
a/sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/CaseInsensitiveMap.scala
+++
b/sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/CaseInsensitiveMap.scala
@@ -30,8 +30,6 @@ import java.util.Locale
class CaseInsensitiveMap[T] private (val originalMap: Map[String, T]) extends
Map[String, T]
with Serializable {
- // Note: this class supports Scala 2.13. A parallel source tree has a 2.12
implementation.
-
val keyLowerCasedMap = originalMap.map(kv => kv.copy(_1 =
kv._1.toLowerCase(Locale.ROOT)))
override def get(k: String): Option[T] =
keyLowerCasedMap.get(k.toLowerCase(Locale.ROOT))
diff --git
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeMap.scala
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeMap.scala
index ac6149f3acc4..b317cacc061b 100644
---
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeMap.scala
+++
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeMap.scala
@@ -41,8 +41,6 @@ object AttributeMap {
class AttributeMap[A](val baseMap: Map[ExprId, (Attribute, A)])
extends Map[Attribute, A] with Serializable {
- // Note: this class supports Scala 2.13. A parallel source tree has a 2.12
implementation.
-
override def get(k: Attribute): Option[A] = baseMap.get(k.exprId).map(_._2)
override def getOrElse[B1 >: A](k: Attribute, default: => B1): B1 =
get(k).getOrElse(default)
diff --git
a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamProgress.scala
b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamProgress.scala
index 6aa1b46cbb94..02f52bb30e1f 100644
---
a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamProgress.scala
+++
b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamProgress.scala
@@ -29,8 +29,6 @@ class StreamProgress(
new immutable.HashMap[SparkDataStream, OffsetV2])
extends scala.collection.immutable.Map[SparkDataStream, OffsetV2] {
- // Note: this class supports Scala 2.13. A parallel source tree has a 2.12
implementation.
-
def toOffsetSeq(source: Seq[SparkDataStream], metadata: OffsetSeqMetadata):
OffsetSeq = {
OffsetSeq(source.map(get), Some(metadata))
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
