This is an automated email from the ASF dual-hosted git repository. yangjie01 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new 22f3221f5db [SPARK-45938][INFRA] Add `utils` to the dependencies of the `core/unsafe/network_common` module in `module.py` 22f3221f5db is described below commit 22f3221f5db88769ae5f999cc4be01cd69a6172e Author: yangjie01 <yangji...@baidu.com> AuthorDate: Thu Nov 16 15:51:26 2023 +0800 [SPARK-45938][INFRA] Add `utils` to the dependencies of the `core/unsafe/network_common` module in `module.py` ### What changes were proposed in this pull request? This pr add `utils` to the dependencies of the `core/unsafe/network_common` module in `module.py` due to `utils` is direct dependency of `core/unsafe/network_common`: https://github.com/apache/spark/blob/7120e6b88f2327ffb71c4bca14b10b15aeb26c32/core/pom.xml#L102-L106 https://github.com/apache/spark/blob/ef93dc247844aca778deda06897a2759ad5eeea4/common/unsafe/pom.xml#L44-L48 https://github.com/apache/spark/blob/ef93dc247844aca778deda06897a2759ad5eeea4/common/network-common/pom.xml#L177-L181 ### Why are the changes needed? All UTs of `utils` module are still in the `core` module now. This pr is used to avoid the issue of not running unit tests in the `core` module when changing the `utils` module. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #43818 from LuciferYang/common-utils-test. Lead-authored-by: yangjie01 <yangji...@baidu.com> Co-authored-by: YangJie <yangji...@baidu.com> Signed-off-by: yangjie01 <yangji...@baidu.com> --- dev/sparktestsupport/modules.py | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/dev/sparktestsupport/modules.py b/dev/sparktestsupport/modules.py index 01757ba28dd..8aa93821637 100644 --- a/dev/sparktestsupport/modules.py +++ b/dev/sparktestsupport/modules.py @@ -113,6 +113,14 @@ tags = Module( ], ) +utils = Module( + name="utils", + dependencies=[tags], + source_file_regexes=[ + "common/utils/", + ], +) + kvstore = Module( name="kvstore", dependencies=[tags], @@ -126,7 +134,7 @@ kvstore = Module( network_common = Module( name="network-common", - dependencies=[tags], + dependencies=[tags, utils], source_file_regexes=[ "common/network-common/", ], @@ -148,7 +156,7 @@ network_shuffle = Module( unsafe = Module( name="unsafe", - dependencies=[tags], + dependencies=[tags, utils], source_file_regexes=[ "common/unsafe", ], @@ -157,14 +165,6 @@ unsafe = Module( ], ) -utils = Module( - name="utils", - dependencies=[tags], - source_file_regexes=[ - "common/utils/", - ], -) - launcher = Module( name="launcher", dependencies=[tags], @@ -178,7 +178,7 @@ launcher = Module( core = Module( name="core", - dependencies=[kvstore, network_common, network_shuffle, unsafe, launcher], + dependencies=[kvstore, network_common, network_shuffle, unsafe, launcher, utils], source_file_regexes=[ "core/", ], --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org