This is an automated email from the ASF dual-hosted git repository. maxgekk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new 70b90c8b5778 [SPARK-46592][DOCKER][TESTS][FOLLOWUP] Add newline to ORACLE Docker preparation sql 70b90c8b5778 is described below commit 70b90c8b5778dc11998cbb5d6dbbb4a3bb7c8145 Author: Kent Yao <y...@apache.org> AuthorDate: Fri Jan 5 11:54:15 2024 +0300 [SPARK-46592][DOCKER][TESTS][FOLLOWUP] Add newline to ORACLE Docker preparation sql ### What changes were proposed in this pull request? `semicolon` is not able to break SQLs in a file into separated statements ### Why are the changes needed? a followup for SPARK-46592 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? Check the Oracle docker log #### Before ``` STDOUT: CONTAINER: running /docker-entrypoint-initdb.d/install.sql ... STDOUT: ALTER SESSION SET DDL_LOCK_TIMEOUT = 30;ALTER USER SYSTEM IDENTIFIED BY "Th1s1sThe0racle#Pass" STDOUT: * STDOUT: ERROR at line 1: STDOUT: ORA-00922: missing or invalid option STDOUT: Help: https://docs.oracle.com/error-help/db/ora-00922/ ``` #### After ``` STDOUT: CONTAINER: DONE: running /docker-entrypoint-initdb.d/install.sql STDOUT: Session altered. STDOUT: User altered. ``` ### Was this patch authored or co-authored using generative AI tooling? no Closes #44609 from yaooqinn/SPARK-46592-F. Authored-by: Kent Yao <y...@apache.org> Signed-off-by: Max Gekk <max.g...@gmail.com> --- .../test/scala/org/apache/spark/sql/jdbc/OracleDatabaseOnDocker.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleDatabaseOnDocker.scala b/connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleDatabaseOnDocker.scala index 9b77469b2f8a..98d57d6a7475 100644 --- a/connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleDatabaseOnDocker.scala +++ b/connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleDatabaseOnDocker.scala @@ -51,7 +51,7 @@ class OracleDatabaseOnDocker extends DatabaseOnDocker with Logging { // means that the lock will no wait. We set the timeout to 30 seconds to try again. // TODO: This workaround should be removed once the issue is fixed in the image. // https://github.com/gvenzl/oci-oracle-free/issues/35 - writer.write("ALTER SESSION SET DDL_LOCK_TIMEOUT = 30;") + writer.write("ALTER SESSION SET DDL_LOCK_TIMEOUT = 30;\n") writer.write(s"""ALTER USER SYSTEM IDENTIFIED BY "$oracle_password";""") writer.close() val newBind = new Bind( --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org