This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new bb0867f54d43 [MINOR][CORE] Fix a comment typo `slf4j-to-jul` to 
`jul-to-slf4j`
bb0867f54d43 is described below

commit bb0867f54d437f6467274e854506aea2900bceb1
Author: Dongjoon Hyun <dh...@apple.com>
AuthorDate: Wed Mar 20 22:01:37 2024 -0700

    [MINOR][CORE] Fix a comment typo `slf4j-to-jul` to `jul-to-slf4j`
    
    ### What changes were proposed in this pull request?
    
    This PR aims to fix a typo `slf4j-to-jul` to `jul-to-slf4j`. There exists 
only one.
    
    ```
    $ git grep slf4j-to-jul
    common/utils/src/main/scala/org/apache/spark/internal/Logging.scala:    // 
slf4j-to-jul bridge order to route their logs to JUL.
    ```
    
    Apache Spark uses `jul-to-slf4j` which includes a `java.util.logging` (jul) 
handler, namely `SLF4JBridgeHandler`, which routes all incoming jul records to 
the SLF4j API.
    
    
https://github.com/apache/spark/blob/bb3e27581887a094ead0d2f7b4a6b2a17ee84b6f/pom.xml#L735
    
    ### Why are the changes needed?
    
    This typo was there since Apache Spark 1.0.0.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No, this is a comment fix.
    
    ### How was this patch tested?
    
    Manual review.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    No.
    
    Closes #45625 from dongjoon-hyun/jul-to-slf4j.
    
    Authored-by: Dongjoon Hyun <dh...@apple.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 common/utils/src/main/scala/org/apache/spark/internal/Logging.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/common/utils/src/main/scala/org/apache/spark/internal/Logging.scala 
b/common/utils/src/main/scala/org/apache/spark/internal/Logging.scala
index 80c622bd5328..c2f61e4d7804 100644
--- a/common/utils/src/main/scala/org/apache/spark/internal/Logging.scala
+++ b/common/utils/src/main/scala/org/apache/spark/internal/Logging.scala
@@ -196,7 +196,7 @@ private[spark] object Logging {
   val initLock = new Object()
   try {
     // We use reflection here to handle the case where users remove the
-    // slf4j-to-jul bridge order to route their logs to JUL.
+    // jul-to-slf4j bridge order to route their logs to JUL.
     val bridgeClass = 
SparkClassUtils.classForName("org.slf4j.bridge.SLF4JBridgeHandler")
     bridgeClass.getMethod("removeHandlersForRootLogger").invoke(null)
     val installed = 
bridgeClass.getMethod("isInstalled").invoke(null).asInstanceOf[Boolean]


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to