This is an automated email from the ASF dual-hosted git repository.

wenchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 3b8aea39953c Revert "[SPARK-47708][CONNECT] Do not log gRPC exception 
to stderr in PySpark
3b8aea39953c is described below

commit 3b8aea39953c254013aad413fd6f727497bc270d
Author: Nemanja Boric <nemanja.bo...@databricks.com>
AuthorDate: Thu Apr 4 21:48:40 2024 +0800

    Revert "[SPARK-47708][CONNECT] Do not log gRPC exception to stderr in 
PySpark
    
    This reverts commit d87ac8ef49dbd7a14d7a774b4ace1ab681a1bb01.
    
    Turns out the sparkconnect logger is disabled by default. This make us 
loose the ability to log the error message if required (by explicitly turning 
on the logger).
    
    ### What changes were proposed in this pull request?
    
    ### Why are the changes needed?
    
    ### Does this PR introduce _any_ user-facing change?
    
    ### How was this patch tested?
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    Closes #45878 from nemanja-boric-databricks/revert-logger.
    
    Authored-by: Nemanja Boric <nemanja.bo...@databricks.com>
    Signed-off-by: Wenchen Fan <wenc...@databricks.com>
---
 python/pyspark/sql/connect/client/core.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/python/pyspark/sql/connect/client/core.py 
b/python/pyspark/sql/connect/client/core.py
index 17b5d99aba94..dd7fae881aec 100644
--- a/python/pyspark/sql/connect/client/core.py
+++ b/python/pyspark/sql/connect/client/core.py
@@ -1719,6 +1719,7 @@ class SparkConnectClient(object):
         -------
         Throws the appropriate internal Python exception.
         """
+        logger.exception("GRPC Error received")
         # We have to cast the value here because, a RpcError is a Call as well.
         # 
https://grpc.github.io/grpc/python/grpc.html#grpc.UnaryUnaryMultiCallable.__call__
         status = rpc_status.from_call(cast(grpc.Call, rpc_error))


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to