This is an automated email from the ASF dual-hosted git repository. gurwls223 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new e521d3c1f357 [MINOR] Fix the grammar of some comments on renaming error classes e521d3c1f357 is described below commit e521d3c1f3578a87e18e5a034705d2520f7b3707 Author: Nicholas Chammas <nicholas.cham...@gmail.com> AuthorDate: Thu May 2 08:46:50 2024 +0900 [MINOR] Fix the grammar of some comments on renaming error classes ### What changes were proposed in this pull request? Minor fixes to the English of some comments I added in #44920. ### Why are the changes needed? Proper English -- OK, not _proper_, but more correct at least -- makes things easier to read. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Not tested beyond CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46321 from nchammas/error-cond-typo. Authored-by: Nicholas Chammas <nicholas.cham...@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls...@apache.org> --- .../utils/src/main/scala/org/apache/spark/SparkThrowableHelper.scala | 2 +- .../main/scala/org/apache/spark/sql/kafka010/KafkaExceptions.scala | 4 ++-- core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala | 2 +- python/pyspark/errors/error_classes.py | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/common/utils/src/main/scala/org/apache/spark/SparkThrowableHelper.scala b/common/utils/src/main/scala/org/apache/spark/SparkThrowableHelper.scala index 6bdafb11e4bd..db5eff72e124 100644 --- a/common/utils/src/main/scala/org/apache/spark/SparkThrowableHelper.scala +++ b/common/utils/src/main/scala/org/apache/spark/SparkThrowableHelper.scala @@ -33,7 +33,7 @@ private[spark] object ErrorMessageFormat extends Enumeration { private[spark] object SparkThrowableHelper { val errorReader = new ErrorClassesJsonReader( // Note that though we call them "error classes" here, the proper name is "error conditions", - // hence why the name of the JSON file different. We will address this inconsistency as part + // hence why the name of the JSON file is different. We will address this inconsistency as part // of this ticket: https://issues.apache.org/jira/browse/SPARK-47429 Seq(SparkClassUtils.getSparkClassLoader.getResource("error/error-conditions.json"))) diff --git a/connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaExceptions.scala b/connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaExceptions.scala index 65688f7db352..8dc4e543060d 100644 --- a/connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaExceptions.scala +++ b/connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaExceptions.scala @@ -27,8 +27,8 @@ private object KafkaExceptionsHelper { val errorClassesJsonReader: ErrorClassesJsonReader = new ErrorClassesJsonReader( // Note that though we call them "error classes" here, the proper name is "error conditions", - // hence why the name of the JSON file different. We will address this inconsistency as part - // of this ticket: https://issues.apache.org/jira/browse/SPARK-47429 + // hence why the name of the JSON file is different. We will address this inconsistency as + // part of this ticket: https://issues.apache.org/jira/browse/SPARK-47429 Seq(getClass.getClassLoader.getResource("error/kafka-error-conditions.json"))) } diff --git a/core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala b/core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala index 9e795c3e32ec..231cfdc3f32f 100644 --- a/core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala +++ b/core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala @@ -51,7 +51,7 @@ class SparkThrowableSuite extends SparkFunSuite { private val errorJsonFilePath = getWorkspaceFilePath( // Note that though we call them "error classes" here, the proper name is "error conditions", - // hence why the name of the JSON file different. We will address this inconsistency as part + // hence why the name of the JSON file is different. We will address this inconsistency as part // of this ticket: https://issues.apache.org/jira/browse/SPARK-47429 "common", "utils", "src", "main", "resources", "error", "error-conditions.json") diff --git a/python/pyspark/errors/error_classes.py b/python/pyspark/errors/error_classes.py index c6b60c79b34d..30869a3fbb2d 100644 --- a/python/pyspark/errors/error_classes.py +++ b/python/pyspark/errors/error_classes.py @@ -19,7 +19,7 @@ import json import importlib.resources # Note: Though we call them "error classes" here, the proper name is "error conditions", -# hence why the name of the JSON file different. +# hence why the name of the JSON file is different. # For more information, please see: https://issues.apache.org/jira/browse/SPARK-46810 # This discrepancy will be resolved as part of: https://issues.apache.org/jira/browse/SPARK-47429 ERROR_CLASSES_JSON = ( --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org