hiwangzhihui commented on code in PR #6352:
URL: https://github.com/apache/hadoop/pull/6352#discussion_r1554610415
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java:
##########
@@ -1118,38 +1123,36 @@ protected void serviceStop() throws Exception {
}
}
- /**
+ /**
* Transition to standby state in a new thread. The transition operation is
* asynchronous to avoid deadlock caused by cyclic dependency.
*/
- private void handleTransitionToStandByInNewThread() {
- Thread standByTransitionThread =
- new Thread(activeServices.standByTransitionRunnable);
- standByTransitionThread.setName("StandByTransitionThread");
- standByTransitionThread.start();
+ void handleTransitionToStandByInNewThread() {
+ toActiveStandbyExecutor.submit(
+ new RMFatalToStandbyRunner(ResourceManager.getClusterTimeStamp()));
Review Comment:
@dineshchitlangia Thank you for your review! Next, I will handle it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
