[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839074#comment-17839074 ]
ASF GitHub Bot commented on HADOOP-19102: ----------------------------------------- steveloughran commented on code in PR #6617: URL: https://github.com/apache/hadoop/pull/6617#discussion_r1572728278 ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/FutureIO.java: ########## @@ -141,9 +145,11 @@ public static <T> List<T> awaitFuture(final Collection<Future<T>> collection) } return results; } catch (InterruptedException e) { + LOG.error("Execution of future interrupted ", e); Review Comment: lets make these a debug() and let the caller handle the the rest. ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/FutureIO.java: ########## @@ -141,9 +145,11 @@ public static <T> List<T> awaitFuture(final Collection<Future<T>> collection) } return results; } catch (InterruptedException e) { + LOG.error("Execution of future interrupted ", e); throw (InterruptedIOException) new InterruptedIOException(e.toString()) .initCause(e); } catch (ExecutionException e) { + LOG.error("Execution of future failed with exception", e.getCause()); Review Comment: log this at debug. handlers up the stack can choose what to do -it may be harmless ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/FutureIO.java: ########## @@ -31,6 +32,8 @@ import java.util.concurrent.Future; import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeoutException; +import org.slf4j.Logger; Review Comment: shouldn't be in same import block as java*. tip: you can set your IDE up for these rules > [ABFS]: FooterReadBufferSize should not be greater than readBufferSize > ---------------------------------------------------------------------- > > Key: HADOOP-19102 > URL: https://issues.apache.org/jira/browse/HADOOP-19102 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure > Affects Versions: 3.4.0 > Reporter: Pranav Saxena > Assignee: Pranav Saxena > Priority: Major > Labels: pull-request-available > > The method `optimisedRead` creates a buffer array of size `readBufferSize`. > If footerReadBufferSize is greater than readBufferSize, abfs will attempt to > read more data than the buffer array can hold, which causes an exception. > Change: To avoid this, we will keep footerBufferSize = > min(readBufferSizeConfig, footerBufferSizeConfig) > > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org