I'd like to propose some sort of comment (non-javadoc) preceding the methods to explain the pattern. Without the institutional day-to-day knowledge, I don't think it is apparent to an outside reader why these methods are crafted as such.
The comment can be as simple as: // wrap native call to allow instrumentation Cheers, Paul On Mon, Aug 11, 2014 at 4:29 PM, Brian Burkhalter < brian.burkhal...@oracle.com> wrote: > > On Aug 11, 2014, at 1:10 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > > This looks okay except SSLSocketImpl#isLayered (not clear why the > override is needed). > > This is needed as it may be required to instrument > sun.security.ssl.SSLSocketImpl.closeSocket() in which the knowledge of > whether the socket is layered has a bearing on the behavior. > > Brian
