On Tue, 31 May 2022 08:37:19 GMT, Adam Sotona <asot...@openjdk.org> wrote:

> This is continuation of PR #4256 
> 
> The patch simply rounds up the specified stack size to multiple of the system 
> page size, on systems where necessary.
> The patch is based on the original PR/branch, with reflected remaining 
> recommendations.
> 
> Please review.
> 
> Thank you,
> Adam

Changes looks good. But the java manpage needs an update too.

Thanks,
David

src/java.base/share/classes/sun/launcher/resources/launcher.properties line 176:

> 174: \    -Xss<size>        set java thread stack size\n\
> 175: \                      The actual size may be rounded up to a multiple 
> of the\n\
> 176: \                      system page size as required by the operating 
> system.\n\

The Java manpage will also need this update.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8953

Reply via email to