> Can I please get a review of this change which addresses > https://bugs.openjdk.java.net/browse/JDK-8285405? > > I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing > `test/jdk/java/util/LinkedHashMap/Basic.java` since that test has tests for > various APIs of this class. > > For `WeakHashMap.newWeakHashMap` and `HashMap.newHashMap`, I have created new > test classes under relevant locations, since these classes already have test > classes (almost) per API/feature in those locations.
Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Add tests for the new HashSet#newHashSet and LinkedHashSet#newLinkedHashSet APIs - add a check for negative numElements very early in the new APIs of HashSet and LinkedHashSet - Merge latest from master branch - 8285405: add test and check for negative argument to HashMap::newHashMap et al ------------- Changes: - all: https://git.openjdk.org/jdk/pull/9036/files - new: https://git.openjdk.org/jdk/pull/9036/files/9ccebd79..07bbaa91 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=9036&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=9036&range=00-01 Stats: 9862 lines in 210 files changed: 8727 ins; 512 del; 623 mod Patch: https://git.openjdk.org/jdk/pull/9036.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9036/head:pull/9036 PR: https://git.openjdk.org/jdk/pull/9036
