On Wed, 30 Nov 2022 21:39:40 GMT, Dean Long <dl...@openjdk.org> wrote:
>> Andrew Haley has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Unused variable > > src/hotspot/share/classfile/javaClasses.cpp line 1731: > >> 1729: } >> 1730: >> 1731: void java_lang_Thread::clear_scopedValueBindings(oop java_thread) { > > It looks like there is only one caller of this method that takes an oop. > Would it make sense to have the caller check for the null oop, and assert > that the oop is not null here? Done. ------------- PR: https://git.openjdk.org/jdk/pull/10952