On Tue, 31 Jan 2023 19:25:55 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Test failed for exception in thread "main" java.lang.IllegalAccessError:
>> class IPv6NameserverPlatformParsingTest (in unnamed module @0x72a8ab1a)
>> cannot access class com.sun.jndi.dns.DnsContextFactory (in module
>> jdk.naming.dns) because module jdk.naming.dns does not export
>> com.sun.jndi.dns to unnamed module @0x72a8ab1a
>> at
>> IPv6NameserverPlatformParsingTest.main(IPv6NameserverPlatformParsingTest.java:46)
>>
>> This task is created to update test instruction to include --add-modules and
>> --add-opens jvm parameters to java command.
>
> test/jdk/com/sun/jndi/dns/Test6991580.java line 66:
>
>> 64: "3. Type \"cd " + System.getProperty("test.classes") + "\".",
>> 65: "4. Type \"" + System.getProperty("java.home") + "/bin/java"
>> 66: + " --add-modules java.desktop,jdk.naming.dns"
>
> I don't think you'll need the --add-modules in the instructions. The
> java.desktop exports as an API so it will be resolved by default, same for
> the java.naming and that will ensure that the JNDI service provider modules
> are resolved.
Thank you for the feedback. I will remove the --add-modules.
-------------
PR: https://git.openjdk.org/jdk/pull/12351
