On Thu, 30 Nov 2023 09:38:22 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Seems a bit odd to me too as the existing simd code seems to C code residing >> in .cpp files for some reason. > > Yeah, that is also a good point. Why setting C++ flags in CFLAGS, and not > just CXXFLAGS? > > Also @vamsi-parasa, did you check into if this really was needed and why? To > be clear, I basically consider this an integration blocker. Hi Magnus (@magicus), The `-std=c++17` flag was to be placed in CXXFLAGS. Will fix that soon. Also, the latest version of x86-simd-sort is using C++17 features (which are supported from GCC 8 onwards). Would it be possible to restrict the availability of simdsort library in OpenJDK to GCC version >= 8 ? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16534#discussion_r1410969089
