On Wed, 7 Feb 2024 10:13:00 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> These 2 classes, the `CheckedInputStream` and the `CheckedOutputStream` are > slightly different from the rest of the classes in this changeset. This > javadoc here is for the constructor of the `CheckedInputStream`. The > implementation of the constructor just blindly assigns the passed argument to > an internal member field and doesn't do any null check on the passed > arguments (any subsequent usage of these instance fields within that class, > then leads to a NullPointerException). The superclasses FilterInputStream and FilterOutputStream have a a protected field for the underlying stream so it's possible for a subclass to set the underlying stream lazily. I can't recall seeing code in the wild availing of that but it is possible. CheckedInputStream and CheckedOutputStream date from JDK 1.1 and it's not clear what the intention was. My guess is that it was an oversight/bug to not check for null when constructing directly. Fixing this will help catch buggy code but it does mean a behavior change. I think we have to keep existing behavior for the subclassing case because it is possible for the subclass to set the stream lazily. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17728#discussion_r1481280976
