On Fri, 16 Feb 2024 15:31:07 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via >> Data- and ObjectInputStream >> >> Testing: tier1-3 > > Claes Redestad has updated the pull request incrementally with two additional > commits since the last revision: > > - Update test/micro/org/openjdk/bench/java/io/DataInputStreamTest.java > > Co-authored-by: Raffaello Giulietti <raffaello.giulie...@oracle.com> > - Update test/micro/org/openjdk/bench/java/io/ObjectInputStreamTest.java > > Co-authored-by: Raffaello Giulietti <raffaello.giulie...@oracle.com> Looks good. src/java.base/share/classes/java/io/DataInputStream.java line 622: > 620: "malformed input around byte " + count); > 621: chararr[chararr_count++]=(char)(((c & 0x1F) << 6) | > 622: (char2 & 0x3F)); Seems like the extra space isn't necessary for alignment. ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17734#pullrequestreview-1901248533 PR Review Comment: https://git.openjdk.org/jdk/pull/17734#discussion_r1502841700
