On Mon, 18 Mar 2024 16:17:41 GMT, Suchismith Roy <s...@openjdk.org> wrote:
>> Allow support for both .a and .so files in AIX. >> If .so file is not found, allow fallback to .a extension. >> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516) > > Suchismith Roy has updated the pull request incrementally with seven > additional commits since the last revision: > > - remove space > - remove debug print lines > - remove debug print lines > - remove debug lines > - variable name check > - code cleanup > - made changes to file loading procedure src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java line 130: > 128: //Remove member name in brackets from > file pathname, as such pathnames do not exist. > 129: //Original pathname with bracket is > returned,which is handled by dlopen() in AIX. > 130: if (file.getName().contains("(")){ Hello @suchismith1993, can you provide us some context on what this check is about? Is some code application code calling `System.load("foo(bar");` and this code in then trying to remove that `(`? Adding this code here wouldn't be right. Plus, I see that in this new `if` block, the code then goes and renames the underlying `File` to a new name, which too isn't right. Knowing the context of why this is needed would help us understand if anything needs to change here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17945#discussion_r1528972710
