On Tue, 2 Apr 2024 02:16:07 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use non-sse fill (old left in) > > This looks like it is still a Draft/work-in-progress. There is only code for > x64 and it doesn't appear it will build on other platforms. Also there are > still a bunch of `if 0` in the code that should not be there. > @dholmes-ora Sorry for the dead code left in. It is gone now. Plus, this was > only requested for x86, thus no implementation for other platforms. Only requested by whom? The JBS issue says nothing about that. I'm not even sure how this avoids the `CheckIntrinsics` check for missing intrinsics ... I guess it must only look for some kind of declaration not an actual implementation. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18555#issuecomment-2038941462
