On Thu, 11 Apr 2024 20:58:00 GMT, Scott Gibbons <sgibb...@openjdk.org> wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 735: >> >>> 733: >>> 734: if (MaxVectorSize == 64) { >>> 735: UnsafeCopyMemoryMark ucmm(this, !is_oop && !aligned, false, >>> ucme_exit_pc); >> >> This is not related to Unsafe::setMemory? > > No. Reviewing the code I saw this as a potential error, as > `arraycopy_avx3_large` could cause a SIGBUS which wouldn't be caught. It > conforms to the other instances of copy in the code. I think it was missed > by the original developer. Would be good to do it in a separate PR then. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18555#discussion_r1561801825